From: void0red <void0red@gmail.com>
To: mudongliangabcd@gmail.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, void0red@gmail.com,
eriri <1527030098@qq.com>
Subject: [PATCH] usb: gadget: udc: replace kzalloc with devm_kzalloc in mv_udc_probe and add a check for this allocation.
Date: Fri, 24 Feb 2023 21:02:35 +0800 [thread overview]
Message-ID: <20230224130235.4028566-1-void0red@gmail.com> (raw)
In-Reply-To: <CAD-N9QX5i5toj8cs7DxBjYWtRGf3ZRnfTAf809sFW6iX0Ktfmw@mail.gmail.com>
From: Kang Chen <void0red@gmail.com>
This driver uses the unified memory management api, so replace
kzalloc with devm_kzalloc to avoid a memory leak and add a check
for this allocation.
Reported-by: eriri <1527030098@qq.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217081
Signed-off-by: Kang Chen <void0red@gmail.com>
---
drivers/usb/gadget/udc/mv_udc_core.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c
index b397f3a84..08474c08d 100644
--- a/drivers/usb/gadget/udc/mv_udc_core.c
+++ b/drivers/usb/gadget/udc/mv_udc_core.c
@@ -2229,7 +2229,11 @@ static int mv_udc_probe(struct platform_device *pdev)
INIT_LIST_HEAD(&udc->status_req->queue);
/* allocate a small amount of memory to get valid address */
- udc->status_req->req.buf = kzalloc(8, GFP_KERNEL);
+ udc->status_req->req.buf = devm_kzalloc(&pdev->dev, 8, GFP_KERNEL);
+ if (!udc->status_req->req.buf) {
+ retval = -ENOMEM;
+ goto err_destroy_dma;
+ }
udc->status_req->req.dma = DMA_ADDR_INVALID;
udc->resume_state = USB_STATE_NOTATTACHED;
--
2.34.1
next prev parent reply other threads:[~2023-02-24 13:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 9:20 [PATCH] usb: gadget: udc: add return value check of kzalloc in mv_udc_probe void0red
2023-02-24 11:03 ` Dongliang Mu
2023-02-24 12:43 ` Kang Chen
2023-02-24 13:02 ` void0red [this message]
2023-02-24 13:13 ` [PATCH] usb: gadget: udc: replace kzalloc with devm_kzalloc in mv_udc_probe and add a check for this allocation Greg KH
2023-02-24 13:14 ` Dongliang Mu
2023-02-24 14:11 ` [PATCH v2] " void0red
2023-02-24 14:19 ` Greg KH
2023-02-24 17:01 ` Sergei Shtylyov
2023-02-25 4:11 ` [PATCH v3 1/2] usb: gadget: udc: add return value check of kzalloc in mv_udc_probe void0red
2023-02-25 4:11 ` [PATCH v3 2/2] usb: gadget: udc: replace kzalloc with devm_kzalloc " void0red
2023-02-24 14:31 ` [PATCH v2] usb: gadget: udc: replace kzalloc with devm_kzalloc in mv_udc_probe and add a check for this allocation void0red
2023-02-24 16:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224130235.4028566-1-void0red@gmail.com \
--to=void0red@gmail.com \
--cc=1527030098@qq.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mudongliangabcd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox