Re: [PATCH v2] usb: gadget: udc: replace kzalloc with devm_kzalloc in mv_udc_probe and add a check for this allocation.

Sergei Shtylyov
2023-02-24T17:01:43Z

Hello!

On 2/24/23 5:11 PM, void0red wrote:

> From: Kang Chen <void0red@gmail.com>
>
> This driver uses the unified memory management api, so replace
> kzalloc with devm_kzalloc to avoid a memory leak and add a check
> for this allocation.

IMHO these are 2 different problems and deserve its own patch
fixing it...

> Reported-by: eriri <1527030098@qq.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217081
>
> Signed-off-by: Kang Chen <void0red@gmail.com>
> ---
> drivers/usb/gadget/udc/mv_udc_core.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c
> index b397f3a84..08474c08d 100644
> --- a/drivers/usb/gadget/udc/mv_udc_core.c
> +++ b/drivers/usb/gadget/udc/mv_udc_core.c
> @@ -2229,7 +2229,11 @@ static int mv_udc_probe(struct platform_device *pdev)
> INIT_LIST_HEAD(&udc->status_req->queue);
>
> /* allocate a small amount of memory to get valid address */
> - udc->status_req->req.buf = kzalloc(8, GFP_KERNEL);
> + udc->status_req->req.buf = devm_kzalloc(&pdev->dev, 8, GFP_KERNEL);
> + if (!udc->status_req->req.buf) {
> + retval = -ENOMEM;
> + goto err_destroy_dma;
> + }
> udc->status_req->req.dma = DMA_ADDR_INVALID;
>
> udc->resume_state = USB_STATE_NOTATTACHED;

MBR, Sergey