From: Wang YanQing <udknight@gmail.com>
To: miquel.raynal@bootlin.com, bbrezillon@kernel.org, richard@nod.at,
vigneshr@ti.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: ubi: eba.c: fix return value overwrite issue in try_write_vid_and_data()
Date: Sun, 26 Feb 2023 22:14:06 +0800 [thread overview]
Message-ID: <20230226141406.GA32048@udknight> (raw)
In-Reply-To: <20230217165442.GA28288@udknight>
On Sat, Feb 18, 2023 at 12:58:08AM +0800, Wang YanQing wrote:
> The commit 2d78aee426d8 ("UBI: simplify LEB write and atomic LEB change code")
> adds helper function, try_write_vid_and_data(), to simplify the code, but this
> helper function has bug, it will return 0 (success) when ubi_io_write_vid_hdr()
> or the ubi_io_write_data() return error number (-EIO, etc), because the return
> value of ubi_wl_put_peb() will overwrite the original return value.
>
> This issue will cause unexpected data loss issue, because the caller of this
> function and UBIFS willn't know the data is lost.
>
> Fixes: 2d78aee426d8 ("UBI: simplify LEB write and atomic LEB change code")
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
Hi! Miquel Raynal
What is the status about this patch?
Thanks!
next prev parent reply other threads:[~2023-02-26 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 16:58 [PATCH] mtd: ubi: eba.c: fix return value overwrite issue in try_write_vid_and_data() Wang YanQing
2023-02-26 14:14 ` Wang YanQing [this message]
2023-02-26 15:52 ` Richard Weinberger
2023-03-20 2:44 ` Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230226141406.GA32048@udknight \
--to=udknight@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox