From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A40BC64ED6 for ; Sun, 26 Feb 2023 14:50:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230123AbjBZOur (ORCPT ); Sun, 26 Feb 2023 09:50:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbjBZOtu (ORCPT ); Sun, 26 Feb 2023 09:49:50 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4A5259C5; Sun, 26 Feb 2023 06:48:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A78BBB80BA8; Sun, 26 Feb 2023 14:48:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7253C433A1; Sun, 26 Feb 2023 14:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677422888; bh=ta7h0pgijq+6wuebfJI+BybH3vX6uklbBdb+V9Ehz44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V4BB7ZI2nVEM7LNScndejcSMyb3I2ILiU2gusMGz1BPcgs0ZMQkBH3r5rjf7HzO57 6kG7QZVrN/4DJRgMSGEiVz1r1Zp1PI7Gdv2uxXp9YtOI7orybbonmLAtciSn0irB2O NXYT43WhZWTsUrwQbwynB2wFtgnmU0GyOwj2AHAifCY0gYqc/mogvglQJW1KUoe7s3 Tlv6wPyazdE8FUybppUKbzqyib/dEdWnyTz3W3RLdYnI2/zCG2kGrLqYHw3xEf3Xh+ r9hFmFGoEms+jyjj2gaArOq9SSgz8l0DPHPkOwdzdWoOO8RS/PdQne2jNYqU5UK2aV osnUGPrvtIHpg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kees Cook , Jan Harkes , coda@cs.cmu.edu, codalist@coda.cs.cmu.edu, Sasha Levin Subject: [PATCH AUTOSEL 6.1 35/49] coda: Avoid partial allocation of sig_inputArgs Date: Sun, 26 Feb 2023 09:46:35 -0500 Message-Id: <20230226144650.826470-35-sashal@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230226144650.826470-1-sashal@kernel.org> References: <20230226144650.826470-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook [ Upstream commit 48df133578c70185a95a49390d42df1996ddba2a ] GCC does not like having a partially allocated object, since it cannot reason about it for bounds checking when it is passed to other code. Instead, fully allocate sig_inputArgs. (Alternatively, sig_inputArgs should be defined as a struct coda_in_hdr, if it is actually not using any other part of the union.) Seen under GCC 13: ../fs/coda/upcall.c: In function 'coda_upcall': ../fs/coda/upcall.c:801:22: warning: array subscript 'union inputArgs[0]' is partly outside array bounds of 'unsigned char[20]' [-Warray-bounds=] 801 | sig_inputArgs->ih.opcode = CODA_SIGNAL; | ^~ Cc: Jan Harkes Cc: coda@cs.cmu.edu Cc: codalist@coda.cs.cmu.edu Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20230127223921.never.882-kees@kernel.org Signed-off-by: Sasha Levin --- fs/coda/upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c index 59f6cfd06f96a..cd6a3721f6f69 100644 --- a/fs/coda/upcall.c +++ b/fs/coda/upcall.c @@ -791,7 +791,7 @@ static int coda_upcall(struct venus_comm *vcp, sig_req = kmalloc(sizeof(struct upc_req), GFP_KERNEL); if (!sig_req) goto exit; - sig_inputArgs = kvzalloc(sizeof(struct coda_in_hdr), GFP_KERNEL); + sig_inputArgs = kvzalloc(sizeof(*sig_inputArgs), GFP_KERNEL); if (!sig_inputArgs) { kfree(sig_req); goto exit; -- 2.39.0