From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
Jan Harkes <jaharkes@cs.cmu.edu>,
coda@cs.cmu.edu, codalist@coda.cs.cmu.edu,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 5.4 17/19] coda: Avoid partial allocation of sig_inputArgs
Date: Sun, 26 Feb 2023 09:51:19 -0500 [thread overview]
Message-ID: <20230226145123.829229-17-sashal@kernel.org> (raw)
In-Reply-To: <20230226145123.829229-1-sashal@kernel.org>
From: Kees Cook <keescook@chromium.org>
[ Upstream commit 48df133578c70185a95a49390d42df1996ddba2a ]
GCC does not like having a partially allocated object, since it cannot
reason about it for bounds checking when it is passed to other code.
Instead, fully allocate sig_inputArgs. (Alternatively, sig_inputArgs
should be defined as a struct coda_in_hdr, if it is actually not using
any other part of the union.) Seen under GCC 13:
../fs/coda/upcall.c: In function 'coda_upcall':
../fs/coda/upcall.c:801:22: warning: array subscript 'union inputArgs[0]' is partly outside array bounds of 'unsigned char[20]' [-Warray-bounds=]
801 | sig_inputArgs->ih.opcode = CODA_SIGNAL;
| ^~
Cc: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: coda@cs.cmu.edu
Cc: codalist@coda.cs.cmu.edu
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230127223921.never.882-kees@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
fs/coda/upcall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c
index eb3b1898da462..610484c90260b 100644
--- a/fs/coda/upcall.c
+++ b/fs/coda/upcall.c
@@ -790,7 +790,7 @@ static int coda_upcall(struct venus_comm *vcp,
sig_req = kmalloc(sizeof(struct upc_req), GFP_KERNEL);
if (!sig_req) goto exit;
- sig_inputArgs = kvzalloc(sizeof(struct coda_in_hdr), GFP_KERNEL);
+ sig_inputArgs = kvzalloc(sizeof(*sig_inputArgs), GFP_KERNEL);
if (!sig_inputArgs) {
kfree(sig_req);
goto exit;
--
2.39.0
next prev parent reply other threads:[~2023-02-26 15:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 14:51 [PATCH AUTOSEL 5.4 01/19] wifi: brcmfmac: Fix potential stack-out-of-bounds in brcmf_c_preinit_dcmds() Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 02/19] rcu: Suppress smp_processor_id() complaint in synchronize_rcu_expedited_wait() Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 03/19] thermal: intel: Fix unsigned comparison with less than zero Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 04/19] timers: Prevent union confusion from unexpected restart_syscall() Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 05/19] x86/bugs: Reset speculation control settings on init Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 06/19] wifi: brcmfmac: ensure CLM version is null-terminated to prevent stack-out-of-bounds Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 07/19] wifi: mt7601u: fix an integer underflow Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 08/19] inet: fix fast path in __inet_hash_connect() Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 09/19] ice: add missing checks for PF vsi type Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 10/19] ACPI: Don't build ACPICA with '-Os' Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 11/19] netpoll: Remove 4s sleep during carrier detection Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 12/19] net: bcmgenet: Add a check for oversized packets Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 13/19] m68k: Check syscall_trace_enter() return code Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 14/19] wifi: mt76: dma: free rx_head in mt76_dma_rx_cleanup Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 15/19] ACPI: video: Fix Lenovo Ideapad Z570 DMI match Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 16/19] net/mlx5: fw_tracer: Fix debug print Sasha Levin
2023-02-26 14:51 ` Sasha Levin [this message]
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 18/19] uaccess: Add minimum bounds check on kernel buffer size Sasha Levin
2023-02-26 14:51 ` [PATCH AUTOSEL 5.4 19/19] devlink: health: Fix nla_nest_end in error flow Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230226145123.829229-17-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=jaharkes@cs.cmu.edu \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox