From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64A4C64ED6 for ; Mon, 27 Feb 2023 02:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231411AbjB0CRN (ORCPT ); Sun, 26 Feb 2023 21:17:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231575AbjB0CPb (ORCPT ); Sun, 26 Feb 2023 21:15:31 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 461CB19BF; Sun, 26 Feb 2023 18:12:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7ADEEB80D2B; Mon, 27 Feb 2023 02:11:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F46AC4339B; Mon, 27 Feb 2023 02:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677463887; bh=ARevy34xSYCEzxzjXEKA5oy9RiNkTxnqxD2Teq/iN6g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bg8JeBIggYaViyGo17r/3WfSlI1+jpSYMukCcN2nayk+7zTqKzyQ/8r5lCZtdwvQG 2JiRNOEA8OdP1kxJDTtLUWSpf16ykXvFA7m61oP8XF4fK04CBCdJR0uEgvr5rmt5na RtGIqOoAP62FzKkC1ter82jjiSu91Hz2pBEpQcrSIOqRkZwGu0U/LKsVpXXmJVhLdo NyGwFcLbbTNqGKIBxXo4hfdNoEMs75/GemIeUjceasXkkuXzkXF+nBYr2cU/ufhWW6 nk7Ihn4Y8pcMbhS0cPjGAV8VykG99rQ//GBH1uv2KEPcAVOqvxWsBWnWxfdsIMrDM2 jC8YfScHJjQfQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kees Cook , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , linux-samsung-soc@vger.kernel.org, Sasha Levin Subject: [PATCH AUTOSEL 4.19 07/10] regulator: s5m8767: Bounds check id indexing into arrays Date: Sun, 26 Feb 2023 21:11:04 -0500 Message-Id: <20230227021110.1053474-7-sashal@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230227021110.1053474-1-sashal@kernel.org> References: <20230227021110.1053474-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook [ Upstream commit e314e15a0b58f9d051c00b25951073bcdae61953 ] The compiler has no way to know if "id" is within the array bounds of the regulators array. Add a check for this and a build-time check that the regulators and reg_voltage_map arrays are sized the same. Seen with GCC 13: ../drivers/regulator/s5m8767.c: In function 's5m8767_pmic_probe': ../drivers/regulator/s5m8767.c:936:35: warning: array subscript [0, 36] is outside array bounds of 'struct regulator_desc[37]' [-Warray-bounds=] 936 | regulators[id].vsel_reg = | ~~~~~~~~~~^~~~ Cc: Krzysztof Kozlowski Cc: Liam Girdwood Cc: Mark Brown Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Kees Cook Reviewed-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20230128005358.never.313-kees@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/s5m8767.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c index 4818df3f8ec91..24c0c82b08a5d 100644 --- a/drivers/regulator/s5m8767.c +++ b/drivers/regulator/s5m8767.c @@ -922,10 +922,14 @@ static int s5m8767_pmic_probe(struct platform_device *pdev) for (i = 0; i < pdata->num_regulators; i++) { const struct sec_voltage_desc *desc; - int id = pdata->regulators[i].id; + unsigned int id = pdata->regulators[i].id; int enable_reg, enable_val; struct regulator_dev *rdev; + BUILD_BUG_ON(ARRAY_SIZE(regulators) != ARRAY_SIZE(reg_voltage_map)); + if (WARN_ON_ONCE(id >= ARRAY_SIZE(regulators))) + continue; + desc = reg_voltage_map[id]; if (desc) { regulators[id].n_voltages = -- 2.39.0