From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE53C7EE31 for ; Mon, 27 Feb 2023 02:16:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231164AbjB0CQX (ORCPT ); Sun, 26 Feb 2023 21:16:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230434AbjB0CN7 (ORCPT ); Sun, 26 Feb 2023 21:13:59 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCA341B33B; Sun, 26 Feb 2023 18:11:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7EC0860CFA; Mon, 27 Feb 2023 02:11:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EE04C433EF; Mon, 27 Feb 2023 02:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677463897; bh=+7Cs4Pr9fcZVRxPC9pnSZsmTMYQjvqYBi6I84wnp8A4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GKvlDk9/BUTovnMGlraGMNkptNU0Wgp82IaEeoZCZqUCQFu2hh/YfQw8tFNEpnEKQ eTzrkePoVB0zA/UYzoMAWXplozPACW4Kfo7voaR60hl2lcHztSBLRVE+5l44kCnzZu rM+Sxz7Z0ESNZooGYoEEc3YMAA/E6i8Ium4lTtm/Wry733ghpoRsyyZolyyVG96ycC ++uIGUgy2RmcK6K08ki/LKeUDVqiOl/ulggHN6/gTB7go4+PeEns6toPoJEpgI36PJ iy2zCdr6ZvXewiDP/3opD1BFbg0BEvpTekbUkvbYCl9feTERqKNBJid5qKeXlLhKbM qdvJCMwbunmfQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiasheng Jiang , Abhinav Kumar , Dmitry Baryshkov , Sasha Levin , robdclark@gmail.com, airlied@gmail.com, daniel@ffwll.ch, marijn.suijten@somainline.org, vkoul@kernel.org, dianders@chromium.org, vladimir.lypak@gmail.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.14 2/9] drm/msm/dsi: Add missing check for alloc_ordered_workqueue Date: Sun, 26 Feb 2023 21:11:24 -0500 Message-Id: <20230227021131.1053662-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230227021131.1053662-1-sashal@kernel.org> References: <20230227021131.1053662-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiasheng Jiang [ Upstream commit 115906ca7b535afb1fe7b5406c566ccd3873f82b ] Add check for the return value of alloc_ordered_workqueue as it may return NULL pointer and cause NULL pointer dereference. Signed-off-by: Jiasheng Jiang Reviewed-by: Abhinav Kumar Patchwork: https://patchwork.freedesktop.org/patch/517646/ Link: https://lore.kernel.org/r/20230110021651.12770-1-jiasheng@iscas.ac.cn Signed-off-by: Dmitry Baryshkov Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index c9c8d21905159..43a3a48a15df5 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -1769,6 +1769,9 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi) /* setup workqueue */ msm_host->workqueue = alloc_ordered_workqueue("dsi_drm_work", 0); + if (!msm_host->workqueue) + return -ENOMEM; + INIT_WORK(&msm_host->err_work, dsi_err_worker); INIT_WORK(&msm_host->hpd_work, dsi_hpd_worker); -- 2.39.0