From: Jean Delvare <jdelvare@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Wolfram Sang <wsa@kernel.org>,
kernel@pengutronix.de, Evgeniy Polyakov <zbr@ioremap.net>,
Crt Mori <cmo@melexis.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9] w1: ds2482: Convert to i2c's .probe_new()
Date: Mon, 27 Feb 2023 13:36:28 +0100 [thread overview]
Message-ID: <20230227133628.403bc581@endymion.delvare> (raw)
In-Reply-To: <20230224120600.1681685-5-u.kleine-koenig@pengutronix.de>
On Fri, 24 Feb 2023 13:05:55 +0100, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Link: https://lore.kernel.org/lkml/20221118224540.619276-596-uwe@kleine-koenig.org
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/w1/masters/ds2482.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
> index 62c44616d8a9..3d8b51316bef 100644
> --- a/drivers/w1/masters/ds2482.c
> +++ b/drivers/w1/masters/ds2482.c
> @@ -442,8 +442,7 @@ static u8 ds2482_w1_set_pullup(void *data, int delay)
> }
>
>
> -static int ds2482_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int ds2482_probe(struct i2c_client *client)
> {
> struct ds2482_data *data;
> int err = -ENODEV;
> @@ -553,7 +552,7 @@ static struct i2c_driver ds2482_driver = {
> .driver = {
> .name = "ds2482",
> },
> - .probe = ds2482_probe,
> + .probe_new = ds2482_probe,
> .remove = ds2482_remove,
> .id_table = ds2482_id,
> };
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2023-02-27 12:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 12:05 [PATCH 0/9] i2c: Switch .probe() to not take an id parameter Uwe Kleine-König
2023-02-24 12:05 ` [PATCH 1/9] misc: ad525x_dpot-i2c: Convert to i2c's .probe_new() Uwe Kleine-König
2023-02-24 12:05 ` [PATCH 2/9] mtd: maps: pismo: " Uwe Kleine-König
2023-02-24 12:05 ` [PATCH 3/9] serial: sc16is7xx: " Uwe Kleine-König
2023-02-24 12:05 ` [PATCH 4/9] w1: ds2482: " Uwe Kleine-König
2023-02-27 12:36 ` Jean Delvare [this message]
2023-02-24 12:05 ` [PATCH 5/9] media: i2c: ov5695: convert " Uwe Kleine-König
2023-02-24 12:41 ` Hans Verkuil
2023-02-24 12:05 ` [PATCH 6/9] media: i2c: ov2685: " Uwe Kleine-König
2023-02-24 12:41 ` Hans Verkuil
2023-02-24 12:05 ` [PATCH 7/9] i2c: Switch .probe() to not take an id parameter Uwe Kleine-König
2023-02-24 16:02 ` Luca Ceresoli
2023-02-24 18:03 ` Uwe Kleine-König
2023-02-24 12:05 ` [PATCH 8/9] i2c: mux: Convert all drivers to new .probe() callback Uwe Kleine-König
2023-02-24 15:23 ` Guenter Roeck
2023-02-24 15:51 ` Peter Rosin
2023-02-24 12:06 ` [PATCH 9/9] i2c: Convert " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227133628.403bc581@endymion.delvare \
--to=jdelvare@suse.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=cmo@melexis.com \
--cc=javierm@redhat.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox