From: Uros Bizjak <ubizjak@gmail.com>
To: rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Uros Bizjak <ubizjak@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>
Subject: [PATCH] rcu: use try_cmpxchg in check_cpu_stall
Date: Tue, 28 Feb 2023 16:51:21 +0100 [thread overview]
Message-ID: <20230228155121.3416-1-ubizjak@gmail.com> (raw)
Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
check_cpu_stall. x86 CMPXCHG instruction returns success in ZF flag, so
this change saves a compare after cmpxchg (and related move instruction in
front of cmpxchg).
No functional change intended.
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>
Cc: Neeraj Upadhyay <quic_neeraju@quicinc.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Joel Fernandes <joel@joelfernandes.org>
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
---
kernel/rcu/tree_stall.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h
index b10b8349bb2a..d81c88e66b42 100644
--- a/kernel/rcu/tree_stall.h
+++ b/kernel/rcu/tree_stall.h
@@ -760,7 +760,7 @@ static void check_cpu_stall(struct rcu_data *rdp)
jn = jiffies + ULONG_MAX / 2;
if (rcu_gp_in_progress() &&
(READ_ONCE(rnp->qsmask) & rdp->grpmask) &&
- cmpxchg(&rcu_state.jiffies_stall, js, jn) == js) {
+ try_cmpxchg(&rcu_state.jiffies_stall, &js, jn)) {
/*
* If a virtual machine is stopped by the host it can look to
@@ -778,7 +778,7 @@ static void check_cpu_stall(struct rcu_data *rdp)
} else if (rcu_gp_in_progress() &&
ULONG_CMP_GE(j, js + RCU_STALL_RAT_DELAY) &&
- cmpxchg(&rcu_state.jiffies_stall, js, jn) == js) {
+ try_cmpxchg(&rcu_state.jiffies_stall, &js, jn)) {
/*
* If a virtual machine is stopped by the host it can look to
--
2.39.2
next reply other threads:[~2023-02-28 15:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 15:51 Uros Bizjak [this message]
2023-02-28 20:39 ` [PATCH] rcu: use try_cmpxchg in check_cpu_stall Joel Fernandes
2023-02-28 20:56 ` Joel Fernandes
2023-02-28 21:03 ` Steven Rostedt
2023-02-28 21:29 ` Paul E. McKenney
2023-02-28 21:41 ` Steven Rostedt
2023-02-28 21:56 ` Paul E. McKenney
2023-02-28 23:30 ` Joel Fernandes
2023-03-01 0:08 ` Steven Rostedt
2023-03-01 0:45 ` Joel Fernandes
2023-03-01 10:28 ` Uros Bizjak
2023-03-01 16:38 ` Steven Rostedt
2023-03-01 18:43 ` Uros Bizjak
2023-03-01 18:52 ` Steven Rostedt
2023-03-01 19:18 ` Uros Bizjak
2023-03-01 19:43 ` Steven Rostedt
2023-03-01 19:46 ` Joel Fernandes
2023-03-01 19:45 ` Joel Fernandes
2023-03-01 20:08 ` Paul E. McKenney
2023-03-01 20:18 ` Joel Fernandes
2023-03-01 20:18 ` Steven Rostedt
2023-03-01 20:36 ` Paul E. McKenney
2023-03-01 20:46 ` Steven Rostedt
2023-03-01 21:29 ` Paul E. McKenney
2023-03-01 9:52 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228155121.3416-1-ubizjak@gmail.com \
--to=ubizjak@gmail.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox