Re: [PATCH v2 1/2] lib/test_string.c: Make definition less dense

Andy Shevchenko
2023-02-28T19:03:42Z

On Tue, Feb 28, 2023 at 8:42 PM Björn Töpel <bjorn@kernel.org> wrote:
>
> From: Björn Töpel <bjorn@rivosinc.com>
>
> Checkpatch seems to have trouble making sense of the situation when
> struct definitions, variable definitions, and __initconst marking is
> done in one go.
>
> Let's be nicer to checkpatch, and move the struct definition out,
> which removes the error.

Not that I'm against the patch, but how hard is it to fix the checkpatch?

In case you go this way with a patch, it probably makes sense to move
test data out of the function as well with something like
strspn_test_data name.

--
With Best Regards,
Andy Shevchenko