From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Ken Sloat <ken.s@variscite.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] net: phy: adin: Add flags to disable enhanced link detection
Date: Tue, 28 Feb 2023 19:31:05 -0800 [thread overview]
Message-ID: <20230228193105.0f378a9d@kernel.org> (raw)
In-Reply-To: <Y/4ba4s37NayCIwW@lunn.ch>
On Tue, 28 Feb 2023 16:19:07 +0100 Andrew Lunn wrote:
> The Marvell PHYs also support a fast link down mode, so i think using
> fast link down everywhere, in the code and the commit message would be
> good. How about adin_fast_down_disable().
Noob question - does this "break the IEEE standard" from the MAC<>PHY
perspective or the media perspective? I'm guessing it's the former
and the setting will depend on the MAC, given configuration via the DT?
next prev parent reply other threads:[~2023-03-01 3:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 14:40 [PATCH v1] net: phy: adin: Add flags to disable enhanced link detection Ken Sloat
2023-02-28 14:53 ` Andrew Lunn
2023-02-28 15:13 ` Ken Sloat
2023-02-28 15:19 ` Andrew Lunn
2023-02-28 15:28 ` Ken Sloat
2023-02-28 15:35 ` Andrew Lunn
2023-03-01 3:31 ` Jakub Kicinski [this message]
2023-03-01 13:02 ` Andrew Lunn
2023-03-01 14:08 ` Ken Sloat
2023-02-28 15:09 ` Nuno Sá
2023-02-28 15:18 ` Ken Sloat
2023-02-28 18:49 ` [PATCH v2 1/2] net: phy: adin: Add flags to allow disabling of fast link down Ken Sloat
2023-02-28 18:49 ` [PATCH v2 2/2] dt-bindings: net: adin: Document bindings for fast link down disable Ken Sloat
2023-03-02 8:59 ` Krzysztof Kozlowski
2023-03-07 18:19 ` Ken Sloat
2023-03-08 10:19 ` Krzysztof Kozlowski
2023-03-01 7:33 ` [PATCH v2 1/2] net: phy: adin: Add flags to allow disabling of fast link down Nuno Sá
2023-03-01 12:32 ` Ken Sloat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228193105.0f378a9d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=ken.s@variscite.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael.hennerich@analog.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox