public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: stable@vger.kernel.org
Cc: "linux-wireless@vger.kernel.org Neo Jou" <neojou@gmail.com>,
	Hans Ulli Kroll <linux@ulli-kroll.de>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Yan-Hsuan Chuang <tony0620emma@gmail.com>,
	Kalle Valo <kvalo@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	kernel@pengutronix.de, Alexander Hochbaum <alex@appudo.com>,
	Da Xue <da@libre.computer>, Po-Hao Huang <phhuang@realtek.com>,
	Andreas Henriksson <andreas@fatal.se>,
	Viktor Petrenko <g0000ga@gmail.com>
Subject: Re: [PATCH v2 0/3] wifi: rtw88: USB fixes
Date: Wed, 1 Mar 2023 08:11:41 +0100	[thread overview]
Message-ID: <20230301071141.GN23347@pengutronix.de> (raw)
In-Reply-To: <20230210111632.1985205-1-s.hauer@pengutronix.de>

On Fri, Feb 10, 2023 at 12:16:29PM +0100, Sascha Hauer wrote:
> This series addresses issues for the recently added RTW88 USB support
> reported by Andreas Henriksson and also our customer.
> 
> The hardware can't handle urbs that have a size of multiple of the
> bulkout_size (usually 512 bytes). The symptom is that the hardware
> stalls completely. The issue can be reproduced by sending a suitably
> sized ping packet from the device:
> 
> ping -s 394 <somehost>
> 
> (It's 394 bytes here on a RTL8822CU and RTL8821CU, the actual size may
> differ on other chips, it was 402 bytes on a RTL8723DU)
> 
> Other than that qsel was not set correctly. The sympton here is that
> only one of multiple bulk endpoints was used to send data.
> 
> Changes since v1:
> - Use URB_ZERO_PACKET to let the USB host controller handle it automatically
>   rather than working around the issue.
> 
> Sascha Hauer (3):
>   wifi: rtw88: usb: Set qsel correctly
>   wifi: rtw88: usb: send Zero length packets if necessary
>   wifi: rtw88: usb: drop now unnecessary URB size check

These patches went in upstream as:

7869b834fb07c wifi: rtw88: usb: Set qsel correctly
07ce9fa6ab0e5 wifi: rtw88: usb: send Zero length packets if necessary
462c8db6a0116 wifi: rtw88: usb: drop now unnecessary URB size check

These patches make the RTW88 USB support much more reliable. Can they be
picked for the current 6.2 stable series please?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2023-03-01  7:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10 11:16 [PATCH v2 0/3] wifi: rtw88: USB fixes Sascha Hauer
2023-02-10 11:16 ` [PATCH v2 1/3] wifi: rtw88: usb: Set qsel correctly Sascha Hauer
2023-02-13  2:50   ` Ping-Ke Shih
2023-02-15  7:50   ` Kalle Valo
2023-02-10 11:16 ` [PATCH v2 2/3] wifi: rtw88: usb: send Zero length packets if necessary Sascha Hauer
2023-02-13  2:51   ` Ping-Ke Shih
2023-02-10 11:16 ` [PATCH v2 3/3] wifi: rtw88: usb: drop now unnecessary URB size check Sascha Hauer
2023-02-13  2:51   ` Ping-Ke Shih
2023-02-10 18:19 ` [PATCH v2 0/3] wifi: rtw88: USB fixes Andreas Henriksson
2023-03-01  7:11 ` Sascha Hauer [this message]
2023-03-01 15:22   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230301071141.GN23347@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=alex@appudo.com \
    --cc=andreas@fatal.se \
    --cc=da@libre.computer \
    --cc=g0000ga@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@ulli-kroll.de \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neojou@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=phhuang@realtek.com \
    --cc=pkshih@realtek.com \
    --cc=stable@vger.kernel.org \
    --cc=tony0620emma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox