From: Saravana Kannan <saravanak@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Len Brown <lenb@kernel.org>
Cc: Saravana Kannan <saravanak@google.com>,
Yongqin Liu <yongqin.liu@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Martin Kepplinger <martin.kepplinger@puri.sm>,
Amelie Delaunay <amelie.delaunay@foss.st.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [PATCH v1 2/4] usb: typec: tipd: Remove use of fw_devlink_purge_absent_suppliers()
Date: Wed, 1 Mar 2023 13:49:49 -0800 [thread overview]
Message-ID: <20230301214952.2190757-3-saravanak@google.com> (raw)
In-Reply-To: <20230301214952.2190757-1-saravanak@google.com>
After recent changes to fw_devlink that ended with commit 4a032827daa8
("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer
cares about the "compatible" property and figures out the correct struct
device at runtime. So, we no longer need to call
fw_devlink_purge_absent_suppliers().
Signed-off-by: Saravana Kannan <saravanak@google.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
---
drivers/usb/typec/tipd/core.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 485b90c13078..92401622bc4e 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -764,16 +764,7 @@ static int tps6598x_probe(struct i2c_client *client)
if (ret < 0)
goto err_clear_mask;
- /*
- * This fwnode has a "compatible" property, but is never populated as a
- * struct device. Instead we simply parse it to read the properties.
- * This breaks fw_devlink=on. To maintain backward compatibility
- * with existing DT files, we work around this by deleting any
- * fwnode_links to/from this fwnode.
- */
fwnode = device_get_named_child_node(&client->dev, "connector");
- if (fwnode)
- fw_devlink_purge_absent_suppliers(fwnode);
tps->role_sw = fwnode_usb_role_switch_get(fwnode);
if (IS_ERR(tps->role_sw)) {
--
2.39.2.722.g9855ee24e9-goog
next prev parent reply other threads:[~2023-03-01 21:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 21:49 [PATCH v1 0/4] Remove use of fw_devlink_purge_absent_suppliers() Saravana Kannan
2023-03-01 21:49 ` [PATCH v1 1/4] usb: typec: stusb160x: " Saravana Kannan
2023-03-06 9:38 ` Heikki Krogerus
2023-03-01 21:49 ` Saravana Kannan [this message]
2023-03-06 9:39 ` [PATCH v1 2/4] usb: typec: tipd: " Heikki Krogerus
2023-03-01 21:49 ` [PATCH v1 3/4] usb: typec: tcpm: " Saravana Kannan
2023-03-06 9:39 ` Heikki Krogerus
2023-03-01 21:49 ` [PATCH v1 4/4] driver core: Delete fw_devlink_purge_absent_suppliers() Saravana Kannan
2023-03-06 9:40 ` Heikki Krogerus
2023-03-02 9:12 ` [PATCH v1 0/4] Remove use of fw_devlink_purge_absent_suppliers() Martin Kepplinger
2023-03-02 9:41 ` Martin Kepplinger
2023-03-10 0:24 ` Saravana Kannan
2023-03-10 10:06 ` Martin Kepplinger
2023-03-10 22:18 ` Saravana Kannan
2023-03-12 14:41 ` Martin Kepplinger
2023-03-13 9:05 ` Martin Kepplinger
2023-03-09 18:04 ` Saravana Kannan
2023-03-09 18:52 ` Yongqin Liu
2023-03-10 0:17 ` Saravana Kannan
2023-03-13 18:42 ` Yongqin Liu
2023-03-10 8:07 ` Greg Kroah-Hartman
2023-03-10 17:20 ` Fabrice Gasnier
2023-03-10 17:40 ` Saravana Kannan
2023-03-15 16:39 ` Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301214952.2190757-3-saravanak@google.com \
--to=saravanak@google.com \
--cc=amelie.delaunay@foss.st.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel-team@android.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.kepplinger@puri.sm \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sumit.semwal@linaro.org \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox