public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Saravana Kannan <saravanak@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Len Brown <lenb@kernel.org>
Cc: Saravana Kannan <saravanak@google.com>,
	Yongqin Liu <yongqin.liu@linaro.org>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Martin Kepplinger <martin.kepplinger@puri.sm>,
	Amelie Delaunay <amelie.delaunay@foss.st.com>,
	kernel-team@android.com, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [PATCH v1 4/4] driver core: Delete fw_devlink_purge_absent_suppliers()
Date: Wed,  1 Mar 2023 13:49:51 -0800	[thread overview]
Message-ID: <20230301214952.2190757-5-saravanak@google.com> (raw)
In-Reply-To: <20230301214952.2190757-1-saravanak@google.com>

After recent changes to fw_devlink that ended with commit 4a032827daa8
("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer
cares about the "compatible" property and figures out the correct struct
device at runtime.

So, there's no need for any driver or framework to call
fw_devlink_purge_absent_suppliers() anymore and we can delete it.

Signed-off-by: Saravana Kannan <saravanak@google.com>
---
 drivers/base/core.c    | 16 ----------------
 include/linux/fwnode.h |  1 -
 2 files changed, 17 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 6878dfcbf0d6..46364c4d1983 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -186,22 +186,6 @@ void fwnode_links_purge(struct fwnode_handle *fwnode)
 	fwnode_links_purge_consumers(fwnode);
 }
 
-void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode)
-{
-	struct fwnode_handle *child;
-
-	/* Don't purge consumer links of an added child */
-	if (fwnode->dev)
-		return;
-
-	fwnode->flags |= FWNODE_FLAG_NOT_DEVICE;
-	fwnode_links_purge_consumers(fwnode);
-
-	fwnode_for_each_available_child_node(fwnode, child)
-		fw_devlink_purge_absent_suppliers(child);
-}
-EXPORT_SYMBOL_GPL(fw_devlink_purge_absent_suppliers);
-
 /**
  * __fwnode_links_move_consumers - Move consumer from @from to @to fwnode_handle
  * @from: move consumers away from this fwnode
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index 5700451b300f..63972c863fcd 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -210,6 +210,5 @@ static inline void fwnode_dev_initialized(struct fwnode_handle *fwnode,
 extern bool fw_devlink_is_strict(void);
 int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup);
 void fwnode_links_purge(struct fwnode_handle *fwnode);
-void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode);
 
 #endif
-- 
2.39.2.722.g9855ee24e9-goog


  parent reply	other threads:[~2023-03-01 21:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01 21:49 [PATCH v1 0/4] Remove use of fw_devlink_purge_absent_suppliers() Saravana Kannan
2023-03-01 21:49 ` [PATCH v1 1/4] usb: typec: stusb160x: " Saravana Kannan
2023-03-06  9:38   ` Heikki Krogerus
2023-03-01 21:49 ` [PATCH v1 2/4] usb: typec: tipd: " Saravana Kannan
2023-03-06  9:39   ` Heikki Krogerus
2023-03-01 21:49 ` [PATCH v1 3/4] usb: typec: tcpm: " Saravana Kannan
2023-03-06  9:39   ` Heikki Krogerus
2023-03-01 21:49 ` Saravana Kannan [this message]
2023-03-06  9:40   ` [PATCH v1 4/4] driver core: Delete fw_devlink_purge_absent_suppliers() Heikki Krogerus
2023-03-02  9:12 ` [PATCH v1 0/4] Remove use of fw_devlink_purge_absent_suppliers() Martin Kepplinger
2023-03-02  9:41   ` Martin Kepplinger
2023-03-10  0:24     ` Saravana Kannan
2023-03-10 10:06       ` Martin Kepplinger
2023-03-10 22:18         ` Saravana Kannan
2023-03-12 14:41           ` Martin Kepplinger
2023-03-13  9:05             ` Martin Kepplinger
2023-03-09 18:04 ` Saravana Kannan
2023-03-09 18:52   ` Yongqin Liu
2023-03-10  0:17     ` Saravana Kannan
2023-03-13 18:42       ` Yongqin Liu
2023-03-10  8:07   ` Greg Kroah-Hartman
2023-03-10 17:20 ` Fabrice Gasnier
2023-03-10 17:40   ` Saravana Kannan
2023-03-15 16:39     ` Fabrice Gasnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230301214952.2190757-5-saravanak@google.com \
    --to=saravanak@google.com \
    --cc=amelie.delaunay@foss.st.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=djrscally@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=kernel-team@android.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=martin.kepplinger@puri.sm \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sumit.semwal@linaro.org \
    --cc=yongqin.liu@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox