From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C148C678D4 for ; Thu, 2 Mar 2023 07:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbjCBH0u (ORCPT ); Thu, 2 Mar 2023 02:26:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbjCBH0q (ORCPT ); Thu, 2 Mar 2023 02:26:46 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE125298CA for ; Wed, 1 Mar 2023 23:26:36 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id u5so13244621plq.7 for ; Wed, 01 Mar 2023 23:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=F3u3LErDLxQpcTw9IoCPajtVtH7Wl04gCGhYoZubMP8=; b=zkjvhExvYB0B4Qs2sggCbs2HJYow4AZ9zqt/ddPcN68B/NhRqd/fHYIc05vyHqguXZ rdItaGWqa2IRY4+HxOiaNJoPqQr+6IqEhaMmPndYTDYXW9VMkwjn0kmI5LdH77EKpMR7 bls32mHRPKTxAe5TWE5VR6SGKlVuHGgWzzexA6cIudfbgNAeNe1Sfc2WAyeeW6dZqqtN C/TLFHEjXVGMOfeXm/HDP20KbV6bCY6ZxPfGCznWckEW5ywTk0vro+Yf8qYRdT0M+Nlw L2xESFFyZ0BLBoYIhuLNiooS9uUP1M62M6ciAntjR+44Nmigwk5ZuiGwJKWA5LzhYYXh T6iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F3u3LErDLxQpcTw9IoCPajtVtH7Wl04gCGhYoZubMP8=; b=z2+XUBUYDmgPfHb5BljEqkO/GrwrRywWm27uIgjWKCkCeiHfKfaY/adsJJGEqNpqLo 1MO/SLeBLuKNXgPwVEifdZcSzGnMj6OKiAu+gJbBceUGwPqbvUmc7hTVHbnaTHyy9zcs Mgm8rY3lHdENVa619hmJ//gU+RUkZf5l6e7Cq0CoPFXTfX2IT11Yw3HCgEKqxk2Hcv3E S7e/n38T04K3d2pbkm59HtRmdfmB411l/iNX7M1AUTQHYLglS9Sp43NsIBVmY0Lusrlz 4Ml3G1ygxlkqhHCjWu5bwvFsLCd0nca5ImQtvrxQTq9UG93lNmiDD/Ypu/Ob/qJFViR6 T/dQ== X-Gm-Message-State: AO0yUKUb+OLmkCk1Moel3Qmxgv6jkBnBYP1rZzFCf1ECULF1BOFPkVBP rAcYmSqU7/9An9QzdCpXAFulkA6l023OcOg= X-Google-Smtp-Source: AK7set+b5+DA7dn3dFlxWvnkmJ1pb3iQAsilUo7zXfjPyk+R+gXDelIQToIayCVkVSQPhcP2Tu7/Kg== X-Received: by 2002:a05:6a20:4c16:b0:cc:d44a:beaf with SMTP id fm22-20020a056a204c1600b000ccd44abeafmr8583578pzb.13.1677741995997; Wed, 01 Mar 2023 23:26:35 -0800 (PST) Received: from thinkpad ([59.97.53.52]) by smtp.gmail.com with ESMTPSA id e18-20020a62aa12000000b00593cd0f37dcsm9077738pff.169.2023.03.01.23.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 23:26:35 -0800 (PST) Date: Thu, 2 Mar 2023 12:56:31 +0530 From: Manivannan Sadhasivam To: Bart Van Assche Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_asutoshd@quicinc.com Subject: Re: [PATCH] ufs: host: ufs-qcom: Return directly if MCQ resource is provided in DT Message-ID: <20230302072631.GA2890@thinkpad> References: <20230301073110.9083-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 01, 2023 at 10:07:41AM -0800, Bart Van Assche wrote: > On 2/28/23 23:31, Manivannan Sadhasivam wrote: > > Instead of using a goto label to return, let's return directly in the > > "if" condition after setting mcq_base. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/ufs/host/ufs-qcom.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > > index 34fc453f3eb1..d90f963eed02 100644 > > --- a/drivers/ufs/host/ufs-qcom.c > > +++ b/drivers/ufs/host/ufs-qcom.c > > @@ -1460,8 +1460,10 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hba *hba) > > /* MCQ resource provided in DT */ > > res = &hba->res[RES_MCQ]; > > /* Bail if MCQ resource is provided */ > > - if (res->base) > > - goto out; > > + if (res->base) { > > + hba->mcq_base = res->base; > > + return 0; > > + } > > /* Explicitly allocate MCQ resource from ufs_mem */ > > res_mcq = devm_kzalloc(hba->dev, sizeof(*res_mcq), GFP_KERNEL); > > @@ -1489,9 +1491,6 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hba *hba) > > goto ioremap_err; > > } > > -out: > > - hba->mcq_base = res->base; > > - return 0; > > ioremap_err: > > res->base = NULL; > > remove_resource(res_mcq); > > This patch changes the behavior for the success case without mentioning this > in the patch description. So I assume that the behavior change is > unintentional and hence that this patch should be dropped? > Sorry, my bad here :( Please ignore this patch. Thanks, Mani > Bart. -- மணிவண்ணன் சதாசிவம்