* Re: [PATCH v2 1/1] ufs: mcq: qcom: Fix passing zero to PTR_ERR
2023-03-02 1:41 [PATCH v2 1/1] ufs: mcq: qcom: Fix passing zero to PTR_ERR Asutosh Das
@ 2023-03-02 2:21 ` Bjorn Andersson
2023-03-02 7:30 ` Manivannan Sadhasivam
2023-03-07 2:57 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-03-02 2:21 UTC (permalink / raw)
To: Asutosh Das
Cc: quic_cang, martin.petersen, linux-scsi, quic_nguyenb,
quic_xiaosenh, stanley.chu, adrian.hunter, bvanassche,
avri.altman, mani, beanhuo, linux-arm-msm, Andy Gross,
Konrad Dybcio, James E.J. Bottomley, open list
On Wed, Mar 01, 2023 at 05:41:06PM -0800, Asutosh Das wrote:
> Fix an error case in ufs_qcom_mcq_config_resource(), where the
> return value is set to 0 before passing it to PTR_ERR.
>
> This led to Smatch warning:
> drivers/ufs/host/ufs-qcom.c:1455 ufs_qcom_mcq_config_resource() warn:
> passing zero to 'PTR_ERR'
>
> Fixes: c263b4ef737e ("scsi: ufs: core: mcq: Configure resource regions")
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
>
> --
> v1 -> v2
> - Split to 2 patches
> - Addressed Mani's comments
> --
> ---
> drivers/ufs/host/ufs-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 34fc453f3eb1..43b1fc1ad33e 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1451,8 +1451,8 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hba *hba)
> if (IS_ERR(res->base)) {
> dev_err(hba->dev, "Failed to map res %s, err=%d\n",
> res->name, (int)PTR_ERR(res->base));
> - res->base = NULL;
> ret = PTR_ERR(res->base);
> + res->base = NULL;
> return ret;
> }
> }
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] ufs: mcq: qcom: Fix passing zero to PTR_ERR
2023-03-02 1:41 [PATCH v2 1/1] ufs: mcq: qcom: Fix passing zero to PTR_ERR Asutosh Das
2023-03-02 2:21 ` Bjorn Andersson
@ 2023-03-02 7:30 ` Manivannan Sadhasivam
2023-03-07 2:57 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-03-02 7:30 UTC (permalink / raw)
To: Asutosh Das
Cc: quic_cang, martin.petersen, linux-scsi, quic_nguyenb,
quic_xiaosenh, stanley.chu, adrian.hunter, bvanassche,
avri.altman, beanhuo, linux-arm-msm, Andy Gross, Bjorn Andersson,
Konrad Dybcio, James E.J. Bottomley, open list
On Wed, Mar 01, 2023 at 05:41:06PM -0800, Asutosh Das wrote:
> Fix an error case in ufs_qcom_mcq_config_resource(), where the
> return value is set to 0 before passing it to PTR_ERR.
>
> This led to Smatch warning:
> drivers/ufs/host/ufs-qcom.c:1455 ufs_qcom_mcq_config_resource() warn:
> passing zero to 'PTR_ERR'
>
> Fixes: c263b4ef737e ("scsi: ufs: core: mcq: Configure resource regions")
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
>
> --
> v1 -> v2
> - Split to 2 patches
> - Addressed Mani's comments
> --
> ---
> drivers/ufs/host/ufs-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 34fc453f3eb1..43b1fc1ad33e 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1451,8 +1451,8 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hba *hba)
> if (IS_ERR(res->base)) {
> dev_err(hba->dev, "Failed to map res %s, err=%d\n",
> res->name, (int)PTR_ERR(res->base));
> - res->base = NULL;
> ret = PTR_ERR(res->base);
> + res->base = NULL;
> return ret;
> }
> }
> --
> 2.7.4
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] ufs: mcq: qcom: Fix passing zero to PTR_ERR
2023-03-02 1:41 [PATCH v2 1/1] ufs: mcq: qcom: Fix passing zero to PTR_ERR Asutosh Das
2023-03-02 2:21 ` Bjorn Andersson
2023-03-02 7:30 ` Manivannan Sadhasivam
@ 2023-03-07 2:57 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-03-07 2:57 UTC (permalink / raw)
To: quic_cang, linux-scsi, Asutosh Das
Cc: Martin K . Petersen, quic_nguyenb, quic_xiaosenh, stanley.chu,
adrian.hunter, bvanassche, avri.altman, mani, beanhuo,
linux-arm-msm, Andy Gross, Bjorn Andersson, Konrad Dybcio,
James E.J. Bottomley, open list
On Wed, 01 Mar 2023 17:41:06 -0800, Asutosh Das wrote:
> Fix an error case in ufs_qcom_mcq_config_resource(), where the
> return value is set to 0 before passing it to PTR_ERR.
>
> This led to Smatch warning:
> drivers/ufs/host/ufs-qcom.c:1455 ufs_qcom_mcq_config_resource() warn:
> passing zero to 'PTR_ERR'
>
> [...]
Applied to 6.3/scsi-fixes, thanks!
[1/1] ufs: mcq: qcom: Fix passing zero to PTR_ERR
https://git.kernel.org/mkp/scsi/c/c8be073bd2bc
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread