Re: [PATCH V3] arm64: defconfig: Enable scm download mode config for IPQ Targets

POOVENDHAN SELVARAJ
2023-02-13T05:08:30Z

On 2/9/2023 3:12 AM, Bjorn Andersson wrote:
> On Wed, Feb 08, 2023 at 11:03:31AM +0530, Poovendhan Selvaraj wrote:
>> Enabling the download mode config by default as the IPQ Targets use
>> crashdump feature extensively to debug crashes.
>>
> No thanks.
>
> You can pass qcom_scm.download_mode=1 on the kernel command line to turn
> this on dynamically when you want it. There's no reason to attempt
> enabling download mode on every Qualcomm board running the upstream
> kernel.
>
> Regards,
> Bjorn

Okay sure...i will remove this patch in next series.

Regards,
Poovendhan S

>> Signed-off-by: Poovendhan Selvaraj <quic_poovendh@quicinc.com>
>> ---
>> Changes in V3:
>> - Updated the commit message
>>
>> arch/arm64/configs/defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 37a60df14e1d..42c9ccdbf0dc 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -258,6 +258,7 @@ CONFIG_ARM_SCPI_PROTOCOL=y
>> CONFIG_RASPBERRYPI_FIRMWARE=y
>> CONFIG_INTEL_STRATIX10_SERVICE=y
>> CONFIG_INTEL_STRATIX10_RSU=m
>> +CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT=y
>> CONFIG_EFI_CAPSULE_LOADER=y
>> CONFIG_IMX_SCU=y
>> CONFIG_IMX_SCU_PD=y
>> --
>> 2.17.1
>>