Re: [PATCH v1 1/4] dt-bindings: mfd: Add DT bindings for TI TPS6594 PMIC

Krzysztof Kozlowski
2023-02-22T08:40:18Z

On 21/02/2023 16:18, Julien Panis wrote:
>>>> It looks the property should be only in the drivers, not in the DT.
>>> I will remove 'ti,use-crc;' property from the DT. This will be only in
>>> the driver.
>>> Do you also consider that a property such as 'ti,is-secondary-pmic;'
>>> would not be acceptable either ? From driver point of view, this
>>> primary/secondary role on SPMI bus is a 'built-in' property of the
>>> PMIC (CRC must be enabled only via primary PMIC but using the
>>> primary PMIC does not imply that CRC is necessarily used).
>> Depends, I am not sure. Are the PMICs in some kind of hierarchical
>> topology? Like one is parent of another? If not (so both are
>> parallel/equal children of SPMI bus), then some property to indicate
>> which one is the main PMIC makes sense.
>
> There is no hierarchical topology.
> So, I will consider identifying in DT which one is the main PMIC.

Yes. Such property would be also better than the "use-crc" as it
describes the hardware, not desired Linux driver behavior.

Best regards,
Krzysztof