From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: <alison.schofield@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, <linux-cxl@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 3/6] cxl/memdev: Add trigger_poison_list sysfs attribute
Date: Fri, 3 Mar 2023 15:42:45 +0000 [thread overview]
Message-ID: <20230303154245.00007b4b@Huawei.com> (raw)
In-Reply-To: <cba540061d48defc0008638bef0cc42cb1f6762e.1676685180.git.alison.schofield@intel.com>
On Fri, 17 Feb 2023 18:18:51 -0800
alison.schofield@intel.com wrote:
> From: Alison Schofield <alison.schofield@intel.com>
>
> When a boolean 'true' is written to this attribute the memdev driver
> retrieves the poison list from the device. The list consists of
> addresses that are poisoned, or would result in poison if accessed,
> and the source of the poison. This attribute is only visible for
> devices supporting the capability. The retrieved errors are logged
> as kernel trace events with the label 'cxl_poison'.
>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Hi Alison,
The dates and version in the docs need an update. Otherwise
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> Documentation/ABI/testing/sysfs-bus-cxl | 14 +++++++
> drivers/cxl/core/memdev.c | 56 +++++++++++++++++++++++++
> drivers/cxl/cxlmem.h | 2 +-
> 3 files changed, 71 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl
> index 3acf2f17a73f..d9421c965a3b 100644
> --- a/Documentation/ABI/testing/sysfs-bus-cxl
> +++ b/Documentation/ABI/testing/sysfs-bus-cxl
> @@ -415,3 +415,17 @@ Description:
> 1), and checks that the hardware accepts the commit request.
> Reading this value indicates whether the region is committed or
> not.
> +
> +
> +What: /sys/bus/cxl/devices/memX/trigger_poison_list
> +Date: November, 2022
> +KernelVersion: v6.2
Needs an update.
> +Contact: linux-cxl@vger.kernel.org
> +Description:
next prev parent reply other threads:[~2023-03-03 15:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 2:18 [PATCH v7 0/6] CXL Poison List Retrieval & Tracing alison.schofield
2023-02-18 2:18 ` [PATCH v7 1/6] cxl/mbox: Add GET_POISON_LIST mailbox command alison.schofield
2023-02-18 2:18 ` [PATCH v7 2/6] cxl/trace: Add TRACE support for CXL media-error records alison.schofield
2023-02-18 2:18 ` [PATCH v7 3/6] cxl/memdev: Add trigger_poison_list sysfs attribute alison.schofield
2023-03-03 15:42 ` Jonathan Cameron [this message]
2023-03-04 5:29 ` Alison Schofield
2023-02-18 2:18 ` [PATCH v7 4/6] cxl/region: Provide region info to the cxl_poison trace event alison.schofield
2023-03-03 16:46 ` Jonathan Cameron
2023-03-03 17:35 ` Alison Schofield
2023-03-04 5:51 ` Alison Schofield
2023-02-18 2:18 ` [PATCH v7 5/6] cxl/trace: Add an HPA to cxl_poison trace events alison.schofield
2023-02-18 2:18 ` [PATCH v7 6/6] tools/testing/cxl: Mock support for Get Poison List alison.schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303154245.00007b4b@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox