From: Joel Fernandes <joel@joelfernandes.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: John Stultz <jstultz@google.com>,
LKML <linux-kernel@vger.kernel.org>, Wei Wang <wvw@google.com>,
Midas Chien <midaschieh@google.com>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Tony Luck <tony.luck@intel.com>,
kernel-team@android.com, Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] pstore: Revert pmsg_lock back to a normal mutex
Date: Sat, 4 Mar 2023 03:23:15 +0000 [thread overview]
Message-ID: <20230304032315.GC2176990@google.com> (raw)
In-Reply-To: <20230304030130.GA2176990@google.com>
On Sat, Mar 04, 2023 at 03:01:30AM +0000, Joel Fernandes wrote:
[...]
> > > > > Either way, I think a comment should go on top of the "if (top_waiter !=
> > > > > waiter)" check IMO.
> > > >
> > > > What type of comment?
> > >
> > > Comment explaining why "if (top_waiter != waiter)" is essential :-).
> >
>
> Maybe "/* Only the top waiter needs to spin. If we are no longer the
> top-waiter, no point in spinning, as we do not get the lock next anyway. */"
>
> ?
And it could be added to that comment that, we want to continue spinning as
long as the top-waiter is still on the CPU (even if we are no longer the
top-waiter).
thanks,
- Joel
next prev parent reply other threads:[~2023-03-04 3:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 6:27 [PATCH] pstore: Revert pmsg_lock back to a normal mutex John Stultz
2023-03-02 13:24 ` Steven Rostedt
2023-03-02 19:39 ` John Stultz
2023-03-02 20:21 ` Steven Rostedt
2023-03-02 21:32 ` Steven Rostedt
2023-03-02 21:36 ` Steven Rostedt
2023-03-02 21:56 ` Steven Rostedt
2023-03-03 1:01 ` Steven Rostedt
2023-03-03 18:11 ` Joel Fernandes
2023-03-03 18:37 ` Steven Rostedt
2023-03-03 19:25 ` Joel Fernandes
2023-03-03 19:38 ` Steven Rostedt
2023-03-03 20:36 ` Qais Yousef
2023-03-04 3:21 ` Joel Fernandes
2023-03-06 19:19 ` Qais Yousef
2023-03-04 3:01 ` Joel Fernandes
2023-03-04 3:23 ` Joel Fernandes [this message]
2023-03-07 14:08 ` Peter Zijlstra
2023-03-07 20:19 ` Joel Fernandes
2023-03-06 18:30 ` John Stultz
2023-03-08 1:31 ` Steven Rostedt
2023-03-08 20:04 ` John Stultz
2023-03-08 20:41 ` Steven Rostedt
2023-03-02 22:41 ` David Laight
2023-03-02 22:53 ` Steven Rostedt
2023-03-04 3:10 ` [PATCH v2] " John Stultz
2023-03-05 16:36 ` Steven Rostedt
2023-03-06 18:27 ` John Stultz
[not found] ` <20230306010323.2909-1-hdanton@sina.com>
2023-03-06 15:28 ` Steven Rostedt
[not found] ` <20230307003106.1768-1-hdanton@sina.com>
2023-03-07 1:58 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2023-03-03 7:06 [PATCH] " Chunhui Li (李春辉)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230304032315.GC2176990@google.com \
--to=joel@joelfernandes.org \
--cc=anton@enomsg.org \
--cc=bigeasy@linutronix.de \
--cc=gpiccoli@igalia.com \
--cc=jstultz@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=midaschieh@google.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox