From: Wei Wang <wei.w.wang@intel.com>
To: arnd@arndb.de, akpm@linux-foundation.org, keescook@chromium.org,
herbert@gondor.apana.org.au, josh@joshtriplett.org,
jani.nikula@intel.com, corbet@lwn.net, jgg@mellanox.com,
dmatlack@google.com, mizhang@google.com, pbonzini@redhat.com,
seanjc@google.com
Cc: linux-kernel@vger.kernel.org, Wei Wang <wei.w.wang@intel.com>
Subject: [PATCH v1 0/3] Regarding using 'bool' appropriately
Date: Sat, 4 Mar 2023 12:19:29 +0800 [thread overview]
Message-ID: <20230304041932.847133-1-wei.w.wang@intel.com> (raw)
When I'm working on patch 3 to change WARN/WARN_ON to use bool for
__ret_warn_on according to the documentation in CodingStyle about using
'bool', compiler reports an error from tpm2_key_encode(), and the root
cause is that it names a variable 'bool' which conficts with the data
type name 'bool'. So fix it and add a rule in CodingStyle to avoid such
naming that causes confusion. This is also the reason that the three
patches are grouped into one patchset.
Wei Wang (3):
security: keys: don't use data type as variable name
Documentation/CodingStyle: do not use data type names as variable
names
bug: use bool for __ret_warn_on in WARN/WARN_ON
Documentation/process/coding-style.rst | 3 +++
include/asm-generic/bug.h | 12 ++++++------
security/keys/trusted-keys/trusted_tpm2.c | 5 +++--
tools/include/asm/bug.h | 10 +++++-----
4 files changed, 17 insertions(+), 13 deletions(-)
--
2.27.0
next reply other threads:[~2023-03-04 4:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 4:19 Wei Wang [this message]
2023-03-04 4:19 ` [PATCH v1 1/3] security: keys: don't use data type as variable name Wei Wang
2023-03-11 22:13 ` Jarkko Sakkinen
2023-03-04 4:19 ` [PATCH v1 2/3] Documentation/CodingStyle: do not use data type names as variable names Wei Wang
2023-03-04 15:01 ` Jonathan Corbet
2023-03-06 11:03 ` Wang, Wei W
2023-03-04 4:19 ` [PATCH v1 3/3] bug: use bool for __ret_warn_on in WARN/WARN_ON Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230304041932.847133-1-wei.w.wang@intel.com \
--to=wei.w.wang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=dmatlack@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=jani.nikula@intel.com \
--cc=jgg@mellanox.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mizhang@google.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox