From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Christian Brauner <brauner@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
linux-kernel@vger.kernel.org
Cc: Ira Weiny <ira.weiny@intel.com>
Subject: [PATCH] fs/sysv: Don't round down address for kunmap_flush_on_unmap()
Date: Mon, 6 Mar 2023 13:51:50 +0100 [thread overview]
Message-ID: <20230306125150.12166-1-fmdefrancesco@gmail.com> (raw)
The kernel virtual address passed to kunmap_flush_on_unmap() has no more
any need to be rounded down.
Therefore, delete the rounding down of "page_addr" when passed to
kunmap_local() in dir_put_page().
Don't backport without commit 88d7b12068b9 ("highmem: round down the
address passed to kunmap_flush_on_unmap()").
Cc: Ira Weiny <ira.weiny@intel.com>
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
fs/sysv/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/sysv/dir.c b/fs/sysv/dir.c
index 999bceb99974..e2d26eb78af7 100644
--- a/fs/sysv/dir.c
+++ b/fs/sysv/dir.c
@@ -30,7 +30,7 @@ const struct file_operations sysv_dir_operations = {
inline void dir_put_page(struct page *page, void *page_addr)
{
- kunmap_local((void *)((unsigned long)page_addr & PAGE_MASK));
+ kunmap_local(page_addr);
put_page(page);
}
--
2.39.2
next reply other threads:[~2023-03-06 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 12:51 Fabio M. De Francesco [this message]
2023-03-06 17:27 ` [PATCH] fs/sysv: Don't round down address for kunmap_flush_on_unmap() Al Viro
2023-03-07 12:22 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306125150.12166-1-fmdefrancesco@gmail.com \
--to=fmdefrancesco@gmail.com \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox