From: Eddie James <eajames@linux.ibm.com>
To: linux-fsi@lists.ozlabs.org
Cc: rostedt@goodmis.org, linux-trace-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mhiramat@kernel.org, alistair@popple.id.au, joel@jms.id.au,
jk@ozlabs.org, andrew@aj.id.au, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, eajames@linux.ibm.com
Subject: [PATCH v8 8/8] fsi: sbefifo: Don't check status during probe
Date: Mon, 6 Mar 2023 10:10:56 -0600 [thread overview]
Message-ID: <20230306161057.44017-9-eajames@linux.ibm.com> (raw)
In-Reply-To: <20230306161057.44017-1-eajames@linux.ibm.com>
The status check during probe doesn't serve any purpose. Any attempt
to use the SBEFIFO will result in the same check and cleanup.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
drivers/fsi/fsi-sbefifo.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
index 9912b7a6a4b9..42d7c95528d1 100644
--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -1027,14 +1027,6 @@ static int sbefifo_probe(struct device *dev)
mutex_init(&sbefifo->lock);
sbefifo->timeout_start_rsp_ms = SBEFIFO_TIMEOUT_START_RSP;
- /*
- * Try cleaning up the FIFO. If this fails, we still register the
- * driver and will try cleaning things up again on the next access.
- */
- rc = sbefifo_cleanup_hw(sbefifo);
- if (rc && rc != -ESHUTDOWN)
- dev_err(dev, "Initial HW cleanup failed, will retry later\n");
-
/* Create chardev for userspace access */
sbefifo->dev.type = &fsi_cdev_type;
sbefifo->dev.parent = dev;
--
2.31.1
prev parent reply other threads:[~2023-03-06 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 16:10 [PATCH v8 0/8] fsi: Add IBM I2C Responder virtual FSI master Eddie James
2023-03-06 16:10 ` [PATCH v8 1/8] fsi: Move fsi_slave structure definition to header Eddie James
2023-03-06 16:10 ` [PATCH v8 2/8] fsi: Make master device indexing and naming optional Eddie James
2023-03-06 16:10 ` [PATCH v8 3/8] dt-bindings: fsi: Document the IBM I2C Responder virtual FSI master Eddie James
2023-03-06 16:10 ` [PATCH v8 4/8] fsi: Add " Eddie James
2023-03-06 16:10 ` [PATCH v8 5/8] fsi: Add I2C Responder SCOM driver Eddie James
2023-03-06 16:10 ` [PATCH v8 6/8] fsi: Add aliased device numbering Eddie James
2023-03-06 16:10 ` [PATCH v8 7/8] fsi: Use of_match_table for bus matching if specified Eddie James
2023-03-06 16:10 ` Eddie James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306161057.44017-9-eajames@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=alistair@popple.id.au \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox