public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: void0red <void0red@gmail.com>
To: void0red@gmail.com
Cc: allenbh@gmail.com, dave.jiang@intel.com, fancer.lancer@gmail.com,
	jdmason@kudzu.us, linux-kernel@vger.kernel.org,
	ntb@lists.linux.dev
Subject: [PATCH v3] ntb_tool: check null return of devm_kcalloc in tool_init_mws
Date: Wed,  8 Mar 2023 00:33:07 +0800	[thread overview]
Message-ID: <20230307163307.132-1-void0red@gmail.com> (raw)
In-Reply-To: <CANE+tVo98AZuRGcAshv5W6v2+fKjTruDVRRdgjfyAVk93cC3_g@mail.gmail.com>

From: Kang Chen <void0red@gmail.com>

devm_kcalloc may fails, tc->peers[pidx].outmws might be null
and will cause null pointer dereference later.

Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Kang Chen <void0red@gmail.com>
---
v3 -> v2: add Reviewed-by tag
v2 -> v1: add Fixes and Reviewed-by tags

 drivers/ntb/test/ntb_tool.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
index 5ee0afa62..eeeb4b1c9 100644
--- a/drivers/ntb/test/ntb_tool.c
+++ b/drivers/ntb/test/ntb_tool.c
@@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
 		tc->peers[pidx].outmws =
 			devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
 				   sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
+		if (tc->peers[pidx].outmws == NULL)
+			return -ENOMEM;
 
 		for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
 			tc->peers[pidx].outmws[widx].pidx = pidx;
-- 
2.34.1


      reply	other threads:[~2023-03-07 16:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-26  5:57 [PATCH] ntb_tool: check null return of devm_kcalloc in tool_init_mws Kang Chen
2023-02-27 15:58 ` Dave Jiang
2023-03-06 15:28 ` Serge Semin
2023-03-07 12:20   ` [PATCH v2] " Kang Chen
2023-03-07 16:05     ` Dave Jiang
2023-03-07 16:26       ` Kang Chen
2023-03-07 16:33         ` void0red [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307163307.132-1-void0red@gmail.com \
    --to=void0red@gmail.com \
    --cc=allenbh@gmail.com \
    --cc=dave.jiang@intel.com \
    --cc=fancer.lancer@gmail.com \
    --cc=jdmason@kudzu.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntb@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox