* [PATCH] ntb_tool: check null return of devm_kcalloc in tool_init_mws
@ 2023-02-26 5:57 Kang Chen
2023-02-27 15:58 ` Dave Jiang
2023-03-06 15:28 ` Serge Semin
0 siblings, 2 replies; 7+ messages in thread
From: Kang Chen @ 2023-02-26 5:57 UTC (permalink / raw)
To: jdmason; +Cc: dave.jiang, allenbh, ntb, linux-kernel, Kang Chen
devm_kcalloc may fails, tc->peers[pidx].outmws might be null
and will cause null pointer dereference later.
Signed-off-by: Kang Chen <void0red@gmail.com>
---
drivers/ntb/test/ntb_tool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
index 5ee0afa62..eeeb4b1c9 100644
--- a/drivers/ntb/test/ntb_tool.c
+++ b/drivers/ntb/test/ntb_tool.c
@@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
tc->peers[pidx].outmws =
devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
+ if (tc->peers[pidx].outmws == NULL)
+ return -ENOMEM;
for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
tc->peers[pidx].outmws[widx].pidx = pidx;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ntb_tool: check null return of devm_kcalloc in tool_init_mws
2023-02-26 5:57 [PATCH] ntb_tool: check null return of devm_kcalloc in tool_init_mws Kang Chen
@ 2023-02-27 15:58 ` Dave Jiang
2023-03-06 15:28 ` Serge Semin
1 sibling, 0 replies; 7+ messages in thread
From: Dave Jiang @ 2023-02-27 15:58 UTC (permalink / raw)
To: Kang Chen, jdmason; +Cc: allenbh, ntb, linux-kernel
On 2/25/23 10:57 PM, Kang Chen wrote:
> devm_kcalloc may fails, tc->peers[pidx].outmws might be null
> and will cause null pointer dereference later.
>
> Signed-off-by: Kang Chen <void0red@gmail.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/ntb/test/ntb_tool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index 5ee0afa62..eeeb4b1c9 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
> tc->peers[pidx].outmws =
> devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
> sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
> + if (tc->peers[pidx].outmws == NULL)
> + return -ENOMEM;
>
> for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
> tc->peers[pidx].outmws[widx].pidx = pidx;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ntb_tool: check null return of devm_kcalloc in tool_init_mws
2023-02-26 5:57 [PATCH] ntb_tool: check null return of devm_kcalloc in tool_init_mws Kang Chen
2023-02-27 15:58 ` Dave Jiang
@ 2023-03-06 15:28 ` Serge Semin
2023-03-07 12:20 ` [PATCH v2] " Kang Chen
1 sibling, 1 reply; 7+ messages in thread
From: Serge Semin @ 2023-03-06 15:28 UTC (permalink / raw)
To: Kang Chen; +Cc: jdmason, dave.jiang, allenbh, ntb, linux-kernel
On Sun, Feb 26, 2023 at 01:57:43PM +0800, Kang Chen wrote:
> devm_kcalloc may fails, tc->peers[pidx].outmws might be null
> and will cause null pointer dereference later.
>
> Signed-off-by: Kang Chen <void0red@gmail.com>
Please add the fixes tag:
Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
so the patch could be noticeable by the stable kernel maintainers.
Other than that looks good.
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
* Please don't forget to add the Rb-tags on v2.
-Serge(y)
> ---
> drivers/ntb/test/ntb_tool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index 5ee0afa62..eeeb4b1c9 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
> tc->peers[pidx].outmws =
> devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
> sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
> + if (tc->peers[pidx].outmws == NULL)
> + return -ENOMEM;
>
> for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
> tc->peers[pidx].outmws[widx].pidx = pidx;
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2] ntb_tool: check null return of devm_kcalloc in tool_init_mws
2023-03-06 15:28 ` Serge Semin
@ 2023-03-07 12:20 ` Kang Chen
2023-03-07 16:05 ` Dave Jiang
0 siblings, 1 reply; 7+ messages in thread
From: Kang Chen @ 2023-03-07 12:20 UTC (permalink / raw)
To: fancer.lancer; +Cc: allenbh, dave.jiang, jdmason, linux-kernel, ntb, void0red
devm_kcalloc may fails, tc->peers[pidx].outmws might be null
and will cause null pointer dereference later.
Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
Signed-off-by: Kang Chen <void0red@gmail.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
---
v2 -> v1: add Fixes and Reviewed-by tags
drivers/ntb/test/ntb_tool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
index 5ee0afa62..eeeb4b1c9 100644
--- a/drivers/ntb/test/ntb_tool.c
+++ b/drivers/ntb/test/ntb_tool.c
@@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
tc->peers[pidx].outmws =
devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
+ if (tc->peers[pidx].outmws == NULL)
+ return -ENOMEM;
for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
tc->peers[pidx].outmws[widx].pidx = pidx;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] ntb_tool: check null return of devm_kcalloc in tool_init_mws
2023-03-07 12:20 ` [PATCH v2] " Kang Chen
@ 2023-03-07 16:05 ` Dave Jiang
2023-03-07 16:26 ` Kang Chen
0 siblings, 1 reply; 7+ messages in thread
From: Dave Jiang @ 2023-03-07 16:05 UTC (permalink / raw)
To: Kang Chen, fancer.lancer; +Cc: allenbh, jdmason, linux-kernel, ntb
On 3/7/23 5:20 AM, Kang Chen wrote:
> devm_kcalloc may fails, tc->peers[pidx].outmws might be null
> and will cause null pointer dereference later.
>
> Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
> Signed-off-by: Kang Chen <void0red@gmail.com>
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
You forgot to pick up my review tag. I do recommend using the tool 'b4'.
It picks up all the tags for you and works rather well.
> ---
> v2 -> v1: add Fixes and Reviewed-by tags
>
> drivers/ntb/test/ntb_tool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index 5ee0afa62..eeeb4b1c9 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
> tc->peers[pidx].outmws =
> devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
> sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
> + if (tc->peers[pidx].outmws == NULL)
> + return -ENOMEM;
>
> for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
> tc->peers[pidx].outmws[widx].pidx = pidx;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] ntb_tool: check null return of devm_kcalloc in tool_init_mws
2023-03-07 16:05 ` Dave Jiang
@ 2023-03-07 16:26 ` Kang Chen
2023-03-07 16:33 ` [PATCH v3] " void0red
0 siblings, 1 reply; 7+ messages in thread
From: Kang Chen @ 2023-03-07 16:26 UTC (permalink / raw)
To: Dave Jiang; +Cc: fancer.lancer, allenbh, jdmason, linux-kernel, ntb
What a cool tool, thanks for your suggestions.
On Wed, Mar 8, 2023 at 12:06 AM Dave Jiang <dave.jiang@intel.com> wrote:
>
>
>
> On 3/7/23 5:20 AM, Kang Chen wrote:
> > devm_kcalloc may fails, tc->peers[pidx].outmws might be null
> > and will cause null pointer dereference later.
> >
> > Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
> > Signed-off-by: Kang Chen <void0red@gmail.com>
> > Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
>
> You forgot to pick up my review tag. I do recommend using the tool 'b4'.
> It picks up all the tags for you and works rather well.
>
> > ---
> > v2 -> v1: add Fixes and Reviewed-by tags
> >
> > drivers/ntb/test/ntb_tool.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> > index 5ee0afa62..eeeb4b1c9 100644
> > --- a/drivers/ntb/test/ntb_tool.c
> > +++ b/drivers/ntb/test/ntb_tool.c
> > @@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
> > tc->peers[pidx].outmws =
> > devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
> > sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
> > + if (tc->peers[pidx].outmws == NULL)
> > + return -ENOMEM;
> >
> > for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
> > tc->peers[pidx].outmws[widx].pidx = pidx;
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v3] ntb_tool: check null return of devm_kcalloc in tool_init_mws
2023-03-07 16:26 ` Kang Chen
@ 2023-03-07 16:33 ` void0red
0 siblings, 0 replies; 7+ messages in thread
From: void0red @ 2023-03-07 16:33 UTC (permalink / raw)
To: void0red; +Cc: allenbh, dave.jiang, fancer.lancer, jdmason, linux-kernel, ntb
From: Kang Chen <void0red@gmail.com>
devm_kcalloc may fails, tc->peers[pidx].outmws might be null
and will cause null pointer dereference later.
Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Kang Chen <void0red@gmail.com>
---
v3 -> v2: add Reviewed-by tag
v2 -> v1: add Fixes and Reviewed-by tags
drivers/ntb/test/ntb_tool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
index 5ee0afa62..eeeb4b1c9 100644
--- a/drivers/ntb/test/ntb_tool.c
+++ b/drivers/ntb/test/ntb_tool.c
@@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
tc->peers[pidx].outmws =
devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
+ if (tc->peers[pidx].outmws == NULL)
+ return -ENOMEM;
for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
tc->peers[pidx].outmws[widx].pidx = pidx;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-07 16:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-26 5:57 [PATCH] ntb_tool: check null return of devm_kcalloc in tool_init_mws Kang Chen
2023-02-27 15:58 ` Dave Jiang
2023-03-06 15:28 ` Serge Semin
2023-03-07 12:20 ` [PATCH v2] " Kang Chen
2023-03-07 16:05 ` Dave Jiang
2023-03-07 16:26 ` Kang Chen
2023-03-07 16:33 ` [PATCH v3] " void0red
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox