public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Peter Tyser <ptyser@xes-inc.com>,
	Andy Shevchenko <andy@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Andrew Davis <afd@ti.com>
Subject: [PATCH 2/6] gpio: twl4030: Use devm_gpiochip_add_data() to simplify remove path
Date: Tue, 7 Mar 2023 10:54:28 -0600	[thread overview]
Message-ID: <20230307165432.25484-2-afd@ti.com> (raw)
In-Reply-To: <20230307165432.25484-1-afd@ti.com>

Use devm version of gpiochip add function to handle removal for us.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 drivers/gpio/gpio-twl4030.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c
index c1bb2c3ca6f2..23f58bf3a415 100644
--- a/drivers/gpio/gpio-twl4030.c
+++ b/drivers/gpio/gpio-twl4030.c
@@ -492,18 +492,6 @@ static struct twl4030_gpio_platform_data *of_gpio_twl4030(struct device *dev,
 	return omap_twl_info;
 }
 
-/* Cannot use as gpio_twl4030_probe() calls us */
-static int gpio_twl4030_remove(struct platform_device *pdev)
-{
-	struct gpio_twl4030_priv *priv = platform_get_drvdata(pdev);
-
-	gpiochip_remove(&priv->gpio_chip);
-
-	/* REVISIT no support yet for deregistering all the IRQs */
-	WARN_ON(!is_module());
-	return 0;
-}
-
 static int gpio_twl4030_probe(struct platform_device *pdev)
 {
 	struct twl4030_gpio_platform_data *pdata = dev_get_platdata(&pdev->dev);
@@ -581,12 +569,9 @@ static int gpio_twl4030_probe(struct platform_device *pdev)
 	if (ret < 0) {
 		dev_err(&pdev->dev, "could not register gpiochip, %d\n", ret);
 		priv->gpio_chip.ngpio = 0;
-		gpio_twl4030_remove(pdev);
 		goto out;
 	}
 
-	platform_set_drvdata(pdev, priv);
-
 	if (pdata->setup) {
 		int status;
 
@@ -615,7 +600,6 @@ static struct platform_driver gpio_twl4030_driver = {
 		.of_match_table = twl_gpio_match,
 	},
 	.probe		= gpio_twl4030_probe,
-	.remove		= gpio_twl4030_remove,
 };
 
 static int __init gpio_twl4030_init(void)
-- 
2.39.2


  reply	other threads:[~2023-03-07 16:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 16:54 [PATCH 1/6] gpio: ich: Use devm_gpiochip_add_data() to simplify remove path Andrew Davis
2023-03-07 16:54 ` Andrew Davis [this message]
2023-03-07 17:45   ` [PATCH 2/6] gpio: twl4030: " Andy Shevchenko
2023-03-07 17:51     ` Andrew Davis
2023-03-07 16:54 ` [PATCH 3/6] gpio: sch311x: " Andrew Davis
2023-03-08 10:24   ` Bartosz Golaszewski
2023-03-08 10:32     ` Bartosz Golaszewski
2023-03-08 15:50       ` Andrew Davis
2023-03-08 15:53         ` Andy Shevchenko
2023-03-08 16:20           ` Andrew Davis
2023-03-08 16:32             ` Andy Shevchenko
2023-03-07 16:54 ` [PATCH 4/6] gpio: pisosr: " Andrew Davis
2023-03-07 17:44   ` Andy Shevchenko
2023-03-07 17:55     ` Andrew Davis
2023-03-07 18:05       ` Andy Shevchenko
2023-03-08 10:27       ` Bartosz Golaszewski
2023-03-07 16:54 ` [PATCH 5/6] gpio: tpic2810: " Andrew Davis
2023-03-08 10:28   ` Bartosz Golaszewski
2023-03-08 10:33     ` Bartosz Golaszewski
2023-03-07 16:54 ` [PATCH 6/6] gpio: tps65086: " Andrew Davis
2023-03-08 10:29   ` Bartosz Golaszewski
2023-03-07 17:41 ` [PATCH 1/6] gpio: ich: " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307165432.25484-2-afd@ti.com \
    --to=afd@ti.com \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ptyser@xes-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox