From: Bjorn Helgaas <helgaas@kernel.org>
To: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Edward Cree <ecree.xilinx@gmail.com>,
Martin Habets <habetsm.xilinx@gmail.com>
Subject: [PATCH 18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()
Date: Tue, 7 Mar 2023 12:19:29 -0600 [thread overview]
Message-ID: <20230307181940.868828-19-helgaas@kernel.org> (raw)
In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org>
From: Bjorn Helgaas <bhelgaas@google.com>
51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to
pci_disable_pcie_error_reporting() in ef100_pci_remove().
Remove this call since there's no apparent reason to disable error
reporting when it was not previously enabled.
Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core enables PCIe error reporting for all devices during
enumeration, so the driver doesn't need to do it itself.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>
Cc: Martin Habets <habetsm.xilinx@gmail.com>
---
drivers/net/ethernet/sfc/ef100.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/sfc/ef100.c b/drivers/net/ethernet/sfc/ef100.c
index 71aab3d0480f..6334992b0af4 100644
--- a/drivers/net/ethernet/sfc/ef100.c
+++ b/drivers/net/ethernet/sfc/ef100.c
@@ -11,7 +11,6 @@
#include "net_driver.h"
#include <linux/module.h>
-#include <linux/aer.h>
#include "efx_common.h"
#include "efx_channels.h"
#include "io.h"
@@ -440,8 +439,6 @@ static void ef100_pci_remove(struct pci_dev *pci_dev)
pci_dbg(pci_dev, "shutdown successful\n");
- pci_disable_pcie_error_reporting(pci_dev);
-
pci_set_drvdata(pci_dev, NULL);
efx_fini_struct(efx);
kfree(probe_data);
--
2.25.1
next prev parent reply other threads:[~2023-03-07 18:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 18:19 [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 01/28] alx: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 02/28] be2net: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 03/28] bnx2: " Bjorn Helgaas
2023-03-08 0:21 ` Michael Chan
2023-03-07 18:19 ` [PATCH 04/28] bnx2x: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 05/28] bnxt: " Bjorn Helgaas
2023-03-08 0:23 ` Michael Chan
2023-03-07 18:19 ` [PATCH 06/28] cxgb4: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 07/28] net/fungible: " Bjorn Helgaas
2023-03-07 19:17 ` Dimitris Michailidis
2023-03-07 18:19 ` [PATCH 08/28] net: hns3: remove unnecessary aer.h include Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 09/28] netxen_nic: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 10/28] octeon_ep: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 11/28] qed: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 12/28] net: qede: Remove unnecessary aer.h include Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 13/28] qlcnic: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 14/28] qlcnic: Remove unnecessary aer.h include Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 15/28] sfc: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-08 16:11 ` Edward Cree
2023-03-07 18:19 ` [PATCH 16/28] sfc: falcon: " Bjorn Helgaas
2023-03-08 16:12 ` Edward Cree
2023-03-07 18:19 ` [PATCH 17/28] sfc/siena: " Bjorn Helgaas
2023-03-08 16:12 ` Edward Cree
2023-03-07 18:19 ` Bjorn Helgaas [this message]
2023-03-08 16:16 ` [PATCH 18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting() Edward Cree
2023-03-07 18:19 ` [PATCH 19/28] net: ngbe: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 20/28] net: txgbe: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 21/28] e1000e: Remove unnecessary aer.h include Bjorn Helgaas
2023-03-15 12:00 ` [Intel-wired-lan] " naamax.meir
2023-03-07 18:19 ` [PATCH 22/28] fm10k: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 23/28] i40e: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 24/28] iavf: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 25/28] ice: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 26/28] igb: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 27/28] igc: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 28/28] ixgbe: " Bjorn Helgaas
2023-03-07 19:28 ` [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Jesse Brandeburg
2023-03-09 7:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307181940.868828-19-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox