From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29ED6C678D5 for ; Wed, 8 Mar 2023 09:43:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbjCHJnr (ORCPT ); Wed, 8 Mar 2023 04:43:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbjCHJnA (ORCPT ); Wed, 8 Mar 2023 04:43:00 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 567A0B8F28; Wed, 8 Mar 2023 01:42:27 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6D69E40011; Wed, 8 Mar 2023 09:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678268541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZIakPN4TFSYdlgwkEYats89Z2k6gICYxrTlj917Vt6U=; b=JLFEk8wZXt7V5TZsangwXm0pBeGRVpyVw+ooUQNA7/s08ZIOuuaYnHyV3TjMZ/yFFG7nJk KwYHrDD7aTo+pRRP9CIetlP3TiGU23MLg2Cxh1sqQJZ8p06WxFHm+rL2mDmYpePr3XGC8n pr4mJJHXUDg60TTFwjfPSCXpivBCjyRPW5b7sK/V/Yus+U3IJ78Wbf2WqJbRDtIKN+RRtr h288ae3AK4EuEx9hyiRKglorXs2++95PKu50pNPhrCxCzisHLXQTNhYKxce5FvHbAOPh8f ZqgLo1otaIXzGqK5zBvK2u84VUiSRk4erhgfpTTU+ZNEzlaokaKI1EnCrIQwuw== Date: Wed, 8 Mar 2023 10:42:20 +0100 From: Alexandre Belloni To: Krzysztof Kozlowski Cc: Svyatoslav Ryhel , Chanwoo Choi , Alessandro Zummo , linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v1] max77663-rtc: pass rtc address from device tree node if exists Message-ID: <202303080942204be1ceeb@mail.local> References: <20230308083759.11692-1-clamor95@gmail.com> <190897d3-39b6-fb7c-dc18-dac580fadea6@linaro.org> <06f8eec8-94f3-0fed-b496-831c77baf368@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <06f8eec8-94f3-0fed-b496-831c77baf368@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2023 10:14:22+0100, Krzysztof Kozlowski wrote: > On 08/03/2023 10:11, Krzysztof Kozlowski wrote: > > On 08/03/2023 09:58, Svyatoslav Ryhel wrote: > >> I would love to, but max77663 uses max77686 rtc > >> https://github.com/torvalds/linux/blob/master/drivers/mfd/max77620.c#L123 > >> how to handle this? > > > > Don't top post. > > > > Hm, so it seems max7763 is already documented via max77620. I missed > > that. Add the new property to max77620, not to max77686 RTC. It does not > > look like RTC's property, but the PMIC's. > > To clarify - the I2C address selection for regmap is in max77686 RTC, > but I meant DT property. > > Different thing is that we do not pass addresses as property fields. > These should be devices on the I2C bus rather... unless you are aware of > existing property like this? > I'd say that the RTC should have been modeled as a discrete component from the beginning instead of using an i2c dummy device > Best regards, > Krzysztof > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com