Re: [PATCH v3 1/3] dt-bindings: remoteproc: k3-m4f: Add bindings for K3 AM64x SoCs

Martyn Welch
2023-03-24T12:01:34Z

On Wed, 2023-03-08 at 13:58 -0700, Mathieu Poirier wrote:
> On Thu, Mar 02, 2023 at 05:14:48PM +0000, Martyn Welch wrote:
>
> > +examples:
> > +  - |
> > +    reserved-memory {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        mcu_m4fss_dma_memory_region: m4f-dma-memory@9cb00000 {
> > +            compatible = "shared-dma-pool";
> > +            reg = <0x00 0x9cb00000 0x00 0x100000>;
> > +            no-map;
> > +        };
> > +
> > +        mcu_m4fss_memory_region: m4f-memory@9cc00000 {
> > +            compatible = "shared-dma-pool";
> > +            reg = <0x00 0x9cc00000 0x00 0xe00000>;
> > +            no-map;
> > +        };
> > +    };
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        mailbox0_cluster0: mailbox-0 {
> > +            #mbox-cells = <1>;
> > +
> > +            mbox_m4_0: mbox-m4-0 {
> > +                ti,mbox-rx = <0 0 0>;
> > +                ti,mbox-tx = <1 0 0>;
> > +            };
> > +        };
> > +
> > +        bus@f0000 {
> > +            compatible = "simple-bus";
> > +            #address-cells = <2>;
> > +            #size-cells = <2>;
> > +            ranges = <0x00 0x04000000 0x00 0x04000000 0x00
> > 0x01ff1400>;
> > +
> > +            bus@4000000 {
> > +                compatible = "simple-bus";
> > +                #address-cells = <2>;
> > +                #size-cells = <2>;
> > +                ranges = <0x00 0x04000000 0x00 0x04000000 0x00
> > 0x01ff1400>;
> > +
> > +                mcu_m4fss: m4fss@5000000 {
> > +                    compatible = "ti,am64-m4fss";
> > +                    reg = <0x00 0x5000000 0x00 0x30000>,
> > +                          <0x00 0x5040000 0x00 0x10000>;
> > +                    reg-names = "iram", "dram";
> > +                    ti,sci = <&dmsc>;
> > +                    ti,sci-dev-id = <9>;
> > +                    ti,sci-proc-ids = <0x18 0xff>;
> > +                    resets = <&k3_reset 9 1>;
> > +                    firmware-name = "am62-mcu-m4f0_0-fw";
> > +                    mboxes = <&mailbox0_cluster0 &mbox_m4_0>;
>
> This doesn't look right since mbox_m4_0 is defined within
> mailbox0_cluster0.
>

Looking at other users of the omap mailboxes (and not wanting to spend
ages trawling back through the mailing list archives to try and work
out why it's specified the way it is) it seems that this is the way
that these mailboxes are specified.

For instance in `arch/arm/boot/dts/omap4-l4.dtsi`, the mailbox is
defined:

mailbox: mailbox@0 {
compatible = "ti,omap4-mailbox";
reg = <0x0 0x200>;
interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
#mbox-cells = <1>;
ti,mbox-num-users = <3>;
ti,mbox-num-fifos = <8>;
mbox_ipu: mbox-ipu {
ti,mbox-tx = <0 0 0>;
ti,mbox-rx = <1 0 0>;
};
mbox_dsp: mbox-dsp {
ti,mbox-tx = <3 0 0>;
ti,mbox-rx = <2 0 0>;
};
};

It's users in `arch/arm/boot/dts/omap4.dtsi`:

dsp: dsp {
...
mboxes = <&mailbox &mbox_dsp>;
...
};

ipu: ipu@55020000 {
...
mboxes = <&mailbox &mbox_ipu>;
...
};

> > +                    memory-region =
> > <&mcu_m4fss_dma_memory_region>,
> > +                                    <&mcu_m4fss_memory_region>;
> > +                };
> > +            };
> > +        };
> > +    };
> > --
> > 2.39.1
> >