From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"hn.chen" <hn.chen@sunplusit.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH RESEND v5 2/5] media: uvcvideo: Quirk for invalid dev_sof in Logitech C922
Date: Thu, 9 Mar 2023 14:30:30 +0900 [thread overview]
Message-ID: <20230309053030.GB1045797@google.com> (raw)
In-Reply-To: <20220920-resend-hwtimestamp-v5-2-139d1a144614@chromium.org>
On (23/03/08 23:45), Ricardo Ribalda wrote:
[..]
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -541,7 +541,13 @@ uvc_video_clock_decode(struct uvc_streaming *stream, struct uvc_buffer *buf,
>
> stream->clock.last_sof = dev_sof;
>
> - host_sof = usb_get_current_frame_number(stream->dev->udev);
What host_sof is set to? Some stack garbage?
> + /*
> + * On some devices, like the Logitech C922, the device SOF does not run
> + * at a stable rate of 1kHz. For those devices use the host SOF instead.
> + */
> + if (stream->dev->quirks & UVC_QUIRK_INVALID_DEVICE_SOF)
> + dev_sof = usb_get_current_frame_number(stream->dev->udev);
> +
> time = uvc_video_get_time();
next prev parent reply other threads:[~2023-03-09 5:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 22:45 [PATCH RESEND v5 0/5] uvcvideo: Fixes for hw timestamping Ricardo Ribalda
2023-03-08 22:45 ` [PATCH RESEND v5 1/5] media: uvc: Ignore empty TS packets Ricardo Ribalda
2023-03-09 5:38 ` Sergey Senozhatsky
2023-03-08 22:45 ` [PATCH RESEND v5 2/5] media: uvcvideo: Quirk for invalid dev_sof in Logitech C922 Ricardo Ribalda
2023-03-09 5:30 ` Sergey Senozhatsky [this message]
2023-03-08 22:45 ` [PATCH RESEND v5 3/5] media: uvcvideo: Allow hw clock updates with buffers not full Ricardo Ribalda
2023-03-08 22:45 ` [PATCH RESEND v5 4/5] media: uvcvideo: Refactor clock circular buffer Ricardo Ribalda
2023-03-09 5:26 ` Sergey Senozhatsky
2023-03-08 22:45 ` [PATCH RESEND v5 5/5] media: uvcvideo: Fix hw timestamp handling for slow FPS Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309053030.GB1045797@google.com \
--to=senozhatsky@chromium.org \
--cc=hn.chen@sunplusit.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox