From: Al Viro <viro@zeniv.linux.org.uk>
To: Christian Brauner <brauner@kernel.org>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] splice: Remove redundant assignment to ret
Date: Fri, 10 Mar 2023 03:48:24 +0000 [thread overview]
Message-ID: <20230310034824.GK3390869@ZenIV> (raw)
In-Reply-To: <167835324320.766837.2963092716601467524.b4-ty@kernel.org>
On Thu, Mar 09, 2023 at 10:15:46AM +0100, Christian Brauner wrote:
> From: Christian Brauner (Microsoft) <brauner@kernel.org>
>
>
> On Tue, 07 Mar 2023 16:49:18 +0800, Jiapeng Chong wrote:
> > The variable ret belongs to redundant assignment and can be deleted.
> >
> > fs/splice.c:940:2: warning: Value stored to 'ret' is never read.
> >
> >
>
> Thanks for the cleanup. Seems ok to do so I picked this up,
>
> [1/1] splice: Remove redundant assignment to ret
> commit: c3a4aec055ec275c9f860e88d37e97248927d898
Which branch?
next prev parent reply other threads:[~2023-03-10 3:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 8:49 [PATCH] splice: Remove redundant assignment to ret Jiapeng Chong
2023-03-09 1:03 ` Chaitanya Kulkarni
2023-03-09 1:03 ` Chaitanya Kulkarni
2023-03-09 9:15 ` Christian Brauner
2023-03-10 3:48 ` Al Viro [this message]
2023-03-10 8:36 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310034824.GK3390869@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=abaci@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox