From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: liao.zenghui@zte.com.cn
Cc: jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
jsd@semihalf.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: fix slave not acknowledge when address matched
Date: Fri, 10 Mar 2023 09:19:22 +0200 [thread overview]
Message-ID: <20230310071922.GZ62143@black.fi.intel.com> (raw)
In-Reply-To: <202303101510464477898@zte.com.cn>
Hi,
On Fri, Mar 10, 2023 at 03:10:46PM +0800, liao.zenghui@zte.com.cn wrote:
> static inline void __i2c_dw_enable(struct dw_i2c_dev *dev)
> {
> + u32 enabled;
> +
> dev->status |= STATUS_ACTIVE;
> - regmap_write(dev->map, DW_IC_ENABLE, 1);
> + regmap_read(dev->map, DW_IC_ENABLE, &enabled);
> + regmap_write(dev->map, DW_IC_ENABLE, enabled | DW_IC_ENABLE_ENABLE);
Looks like this patch has some whitespace damage. Probably good to use
git send-email or so to make sure the formatting stays intact.
prev parent reply other threads:[~2023-03-10 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 7:10 [PATCH] i2c: designware: fix slave not acknowledge when address matched liao.zenghui
2023-03-10 7:19 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310071922.GZ62143@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=liao.zenghui@zte.com.cn \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox