* [PATCH] hwmon: (ina3221) return prober error code
@ 2023-03-10 7:50 Marcus Folkesson
2023-03-10 16:34 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Marcus Folkesson @ 2023-03-10 7:50 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck; +Cc: linux-hwmon, linux-kernel, Marcus Folkesson
ret is set to 0 which do not indicate an error.
Return -EINVAL instead.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/hwmon/ina3221.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
index e06186986444..f3a4c5633b1e 100644
--- a/drivers/hwmon/ina3221.c
+++ b/drivers/hwmon/ina3221.c
@@ -772,7 +772,7 @@ static int ina3221_probe_child_from_dt(struct device *dev,
return ret;
} else if (val > INA3221_CHANNEL3) {
dev_err(dev, "invalid reg %d of %pOFn\n", val, child);
- return ret;
+ return -EINVAL;
}
input = &ina->inputs[val];
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hwmon: (ina3221) return prober error code
2023-03-10 7:50 [PATCH] hwmon: (ina3221) return prober error code Marcus Folkesson
@ 2023-03-10 16:34 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2023-03-10 16:34 UTC (permalink / raw)
To: Marcus Folkesson; +Cc: Jean Delvare, linux-hwmon, linux-kernel
On Fri, Mar 10, 2023 at 08:50:35AM +0100, Marcus Folkesson wrote:
> ret is set to 0 which do not indicate an error.
> Return -EINVAL instead.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/ina3221.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
> index e06186986444..f3a4c5633b1e 100644
> --- a/drivers/hwmon/ina3221.c
> +++ b/drivers/hwmon/ina3221.c
> @@ -772,7 +772,7 @@ static int ina3221_probe_child_from_dt(struct device *dev,
> return ret;
> } else if (val > INA3221_CHANNEL3) {
> dev_err(dev, "invalid reg %d of %pOFn\n", val, child);
> - return ret;
> + return -EINVAL;
> }
>
> input = &ina->inputs[val];
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-10 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-10 7:50 [PATCH] hwmon: (ina3221) return prober error code Marcus Folkesson
2023-03-10 16:34 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox