From: Manivannan Sadhasivam <mani@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Slark Xiao <slark_xiao@163.com>,
loic.poulain@linaro.org, fabio.porcedda@gmail.com,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: mhi: host: pci_generic: Revert "Add a secondary AT port to Telit FN990"
Date: Fri, 10 Mar 2023 17:57:54 +0530 [thread overview]
Message-ID: <20230310122754.GD6838@thinkpad> (raw)
In-Reply-To: <c5bc74dc-4926-9830-069a-fb30fbaf3189@linaro.org>
On Fri, Mar 10, 2023 at 02:18:23PM +0200, Dmitry Baryshkov wrote:
> On 10/03/2023 12:17, Slark Xiao wrote:
> > This reverts commit 2d5253a096c6057bbf7caa5520856dcdf7eca8bb.
> > There are 2 commits with commit message "Add a secondary AT
> > port to Telit FN990". But the last one 2d5253a096 was added
> > on Foxconn devices. Actually the second AT port of Foxconn
> > devices doesn't work in PCIe mode. And the commit message
> > mismatch with the changes. So we need to remove it.
> >
> > Signed-off-by: Slark Xiao <slark_xiao@163.com>
>
> Probably also:
>
> Fixes: 2d5253a096c6 ("bus: mhi: host: pci_generic: Add a secondary AT port
> to Telit FN990")
>
Added fixes tag and CCed stable for backporting to 6.2.
Thanks,
Mani
> > ---
> > drivers/bus/mhi/host/pci_generic.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> > index 6e13c43a84d1..91d02f84ba21 100644
> > --- a/drivers/bus/mhi/host/pci_generic.c
> > +++ b/drivers/bus/mhi/host/pci_generic.c
> > @@ -343,8 +343,6 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
> > MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> > MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> > MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> > - MHI_CHANNEL_CONFIG_UL(92, "DUN2", 32, 1),
> > - MHI_CHANNEL_CONFIG_DL(93, "DUN2", 32, 1),
> > MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> > MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> > };
>
> --
> With best wishes
> Dmitry
>
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2023-03-10 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 10:17 [PATCH] bus: mhi: host: pci_generic: Revert "Add a secondary AT port to Telit FN990" Slark Xiao
2023-03-10 10:31 ` Manivannan Sadhasivam
2023-03-10 10:33 ` Fabio Porcedda
2023-03-10 12:02 ` Manivannan Sadhasivam
2023-03-10 12:13 ` Manivannan Sadhasivam
2023-03-10 12:18 ` Dmitry Baryshkov
2023-03-10 12:27 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310122754.GD6838@thinkpad \
--to=mani@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabio.porcedda@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=slark_xiao@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox