Re: [PATCH v4 1/4] PCI: Introduce pci_dev_for_each_resource()

Andy Shevchenko
2023-03-14T18:46:04Z

On Sat, Mar 11, 2023 at 04:54:32PM +0300, Dan Carpenter wrote:

> 059b4a086017fb Mika Westerberg 2023-03-10 246 unsigned long type = resource_type(r);
> 999ed65ad12e37 Rene Herman 2008-07-25 247
> 059b4a086017fb Mika Westerberg 2023-03-10 @248 if (type != IORESOURCE_IO || type != IORESOURCE_MEM ||
> ^^
> This || needs to be &&. This loop will always hit the continue path
> without doing anything.
>
> 059b4a086017fb Mika Westerberg 2023-03-10 249 resource_size(r) == 0)
> 0509ad5e1a7d92 Bjorn Helgaas 2008-03-11 250 continue;

Thanks, I'll fix in v5.

--
With Best Regards,
Andy Shevchenko