From: Andreas Kemnade <andreas@kemnade.info>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
arnd@arndb.de, olof@lixom.net, soc@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
marex@denx.de, max.krummenacher@toradex.com, leoyang.li@nxp.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Tolino Vison
Date: Sun, 12 Mar 2023 22:40:36 +0100 [thread overview]
Message-ID: <20230312224036.37dc4d41@aktux> (raw)
In-Reply-To: <1346ce4e-f1fd-1a77-f38e-cd87efc59082@linaro.org>
On Sun, 12 Mar 2023 22:02:24 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 12/03/2023 21:52, Andreas Kemnade wrote:
> > This adds a devicetree for the Kobo Aura 2 Ebook reader. It is based
> > on boards marked with "37NB-E60Q30+4A3". It is equipped with an i.MX6SL
> > SoC.
> >
>
> Thank you for your patch. There is something to discuss/improve.
[...]
> > + pinctrl_i2c2: i2c2grp {
> > + fsl,pins = <
> > + MX6SL_PAD_I2C2_SCL__I2C2_SCL 0x4001f8b1
> > + MX6SL_PAD_I2C2_SDA__I2C2_SDA 0x4001f8b1
> > + >;
> > + };
> > +
> > + pinctrl_i2c2_sleep: i2c2grp-sleep {
>
> Shouldn't all groups end with 'grp' suffix? Are you sure this passes
> dtbs_check?
>
> ...
>
No problem with dtbs_check. But I will resend with corrected names.
Regards,
Andreas
next prev parent reply other threads:[~2023-03-12 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 20:52 [PATCH 0/2] ARM: dts: Add Tolino Vision Andreas Kemnade
2023-03-12 20:52 ` [PATCH 1/2] dt-bindings: arm: fsl: add compatible string for " Andreas Kemnade
2023-03-12 20:59 ` Krzysztof Kozlowski
2023-03-12 20:52 ` [PATCH 2/2] ARM: dts: imx: Add devicetree for Tolino Vison Andreas Kemnade
2023-03-12 21:02 ` Krzysztof Kozlowski
2023-03-12 21:40 ` Andreas Kemnade [this message]
2023-03-13 0:01 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230312224036.37dc4d41@aktux \
--to=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=max.krummenacher@toradex.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox