From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Sanjay R Mehta <sanju.mehta@amd.com>,
anson.tsao@amd.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] thunderbolt: Disable interrupt auto clear for rings
Date: Mon, 13 Mar 2023 07:46:54 +0200 [thread overview]
Message-ID: <20230313054654.GC62143@black.fi.intel.com> (raw)
In-Reply-To: <20230310172050.1394-3-mario.limonciello@amd.com>
Hi Mario,
On Fri, Mar 10, 2023 at 11:20:50AM -0600, Mario Limonciello wrote:
> When interrupt auto clear is programmed, any read to the interrupt
> status register will clear all interrupts. If two interrupts have
> come in before one can be serviced then this will cause lost interrupts.
>
> On AMD USB4 routers this has manifested in odd problems particularly
> with long strings of control tranfers such as reading the DROM via bit
> banging.
Nice catch! Does this mean we can drop [1] now?
[1] https://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git/commit/?h=next&id=8d7f459107f74fbbdde3dd5b3874d2e748cb8a21
I would still like to keep the nice refactor you did for the DROM
parsing, though.
next prev parent reply other threads:[~2023-03-13 5:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 17:20 [PATCH 0/2] Fix TX/RX interrupt handling Mario Limonciello
2023-03-10 17:20 ` [PATCH 1/2] thunderbolt: Use const qualifier for `ring_interrupt_index` Mario Limonciello
2023-03-10 17:20 ` [PATCH 2/2] thunderbolt: Disable interrupt auto clear for rings Mario Limonciello
2023-03-13 5:46 ` Mika Westerberg [this message]
2023-03-14 14:28 ` [PATCH 0/2] Fix TX/RX interrupt handling Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313054654.GC62143@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=anson.tsao@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=sanju.mehta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox