From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0394EC6FD19 for ; Mon, 13 Mar 2023 15:04:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbjCMPEa (ORCPT ); Mon, 13 Mar 2023 11:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229801AbjCMPE2 (ORCPT ); Mon, 13 Mar 2023 11:04:28 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DE8F6A1EB for ; Mon, 13 Mar 2023 08:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678719838; x=1710255838; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nnPVxqaWPSM62/7tvPcwit7boeqwp9uA7g0BvtONDlc=; b=kQGQO1HlNu8HWrUQmXuHKDRVVscpvub4l1lwQhrnMd8LWyKnlpIArCTS vrmQ/mpI30jfXQp7GsosabL9FoJspkVWBDLK1+58SccwraridOOhxVvKl DQf25zZ9BghFXalhNH6FigXvg4AQ5G3/UzZMd0wJ1/FLQNEaqUgWbKtYI 9VUMmFXlDKabzzztw1u+k5OfqDECt3e1scu0w69/QTpAg1X8fhcB5Ccch BOyHTtPhz2ab8rrZpnBq5pEZ9m9uULJFcVqmVod/hMj435bUMArwY8JdH OtyEtQJE3uVNcSMu4/FCEkC4f0HfDJrxT6cf8Md/1cfpk9I/4YXYBJOcP Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10648"; a="339536930" X-IronPort-AV: E=Sophos;i="5.98,257,1673942400"; d="scan'208";a="339536930" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2023 08:03:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10648"; a="1008016668" X-IronPort-AV: E=Sophos;i="5.98,257,1673942400"; d="scan'208";a="1008016668" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 13 Mar 2023 08:03:25 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pbjhs-0005n0-1m; Mon, 13 Mar 2023 15:03:24 +0000 Date: Mon, 13 Mar 2023 23:02:35 +0800 From: kernel test robot To: Song Shuai , sudeep.holla@arm.com, gregkh@linuxfoundation.org, rafael@kernel.org, conor.dooley@microchip.com, ionela.voinescu@arm.com Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Song Shuai Subject: Re: [PATCH] arch_topology: Clear LLC sibling when cacheinfo teardown Message-ID: <202303132209.invDMo8L-lkp@intel.com> References: <20230313102752.1134472-1-suagrfillet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230313102752.1134472-1-suagrfillet@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Song, Thank you for the patch! Yet something to improve: [auto build test ERROR on driver-core/driver-core-testing] [also build test ERROR on driver-core/driver-core-next driver-core/driver-core-linus linus/master v6.3-rc2 next-20230310] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Song-Shuai/arch_topology-Clear-LLC-sibling-when-cacheinfo-teardown/20230313-182946 patch link: https://lore.kernel.org/r/20230313102752.1134472-1-suagrfillet%40gmail.com patch subject: [PATCH] arch_topology: Clear LLC sibling when cacheinfo teardown config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230313/202303132209.invDMo8L-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/a9aca0a81b31b421e3bbfa08fd205a8bec651afe git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Song-Shuai/arch_topology-Clear-LLC-sibling-when-cacheinfo-teardown/20230313-182946 git checkout a9aca0a81b31b421e3bbfa08fd205a8bec651afe # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303132209.invDMo8L-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/base/cacheinfo.c: In function 'cacheinfo_cpu_pre_down': >> drivers/base/cacheinfo.c:818:9: error: implicit declaration of function 'clear_llc_topology' [-Werror=implicit-function-declaration] 818 | clear_llc_topology(cpu); | ^~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/clear_llc_topology +818 drivers/base/cacheinfo.c 811 812 static int cacheinfo_cpu_pre_down(unsigned int cpu) 813 { 814 if (cpumask_test_and_clear_cpu(cpu, &cache_dev_map)) 815 cpu_cache_sysfs_exit(cpu); 816 817 free_cache_attributes(cpu); > 818 clear_llc_topology(cpu); 819 return 0; 820 } 821 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests