From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC6C0C74A5B for ; Tue, 14 Mar 2023 12:44:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231830AbjCNMoN (ORCPT ); Tue, 14 Mar 2023 08:44:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbjCNMnv (ORCPT ); Tue, 14 Mar 2023 08:43:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2A239F23B; Tue, 14 Mar 2023 05:43:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C6B46175A; Tue, 14 Mar 2023 12:43:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FA08C4339C; Tue, 14 Mar 2023 12:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678797795; bh=6BjCbJe3yeBFWIjm8HU9/LEHEJ3td8ALArsN78304o8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=noLQv5c/MeUTHDxMFcDNFv1ZJ/0mUs/HxiGLfE3Wb8cM3lBBkG+LE2LpiEQuRrjQO BS78xGbxF8W4nh0Y56ooMLnNfLxC9we5NWGk37L83JmhwhCTGVB+A/IX1P68SawJmN Qa6a12ZwCVaySne49Hsv8JS1GRBmo513GE8V7X315KPD52bZDkfnuS3Aj6wzbhoS0C 6zloFk/ZDGoiymY4/zQxVtJhG6GR1rZS7XrOlUWhER4RBW7ZWmWiImprrzd4UqyHyi NIAlZPoaoQ5qW46litWYbZd/xrDrN34g5KtwXnV3eQbOsAhut5aFo85yUZKM3GPdRn PIjw/N0LpN4nw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Baokun Li , =?UTF-8?q?Lu=C3=ADs=20Henriques?= , Jan Kara , Theodore Ts'o , Sasha Levin , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Subject: [PATCH AUTOSEL 6.2 06/13] ext4: update s_journal_inum if it changes after journal replay Date: Tue, 14 Mar 2023 08:42:58 -0400 Message-Id: <20230314124305.470657-6-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230314124305.470657-1-sashal@kernel.org> References: <20230314124305.470657-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Baokun Li [ Upstream commit 3039d8b8692408438a618fac2776b629852663c3 ] When mounting a crafted ext4 image, s_journal_inum may change after journal replay, which is obviously unreasonable because we have successfully loaded and replayed the journal through the old s_journal_inum. And the new s_journal_inum bypasses some of the checks in ext4_get_journal(), which may trigger a null pointer dereference problem. So if s_journal_inum changes after the journal replay, we ignore the change, and rewrite the current journal_inum to the superblock. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216541 Reported-by: Luís Henriques Signed-off-by: Baokun Li Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20230107032126.4165860-3-libaokun1@huawei.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/super.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index c81fa0fa9901a..e79ca9ef98316 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5967,8 +5967,11 @@ static int ext4_load_journal(struct super_block *sb, if (!really_read_only && journal_devnum && journal_devnum != le32_to_cpu(es->s_journal_dev)) { es->s_journal_dev = cpu_to_le32(journal_devnum); - - /* Make sure we flush the recovery flag to disk. */ + ext4_commit_super(sb); + } + if (!really_read_only && journal_inum && + journal_inum != le32_to_cpu(es->s_journal_inum)) { + es->s_journal_inum = cpu_to_le32(journal_inum); ext4_commit_super(sb); } -- 2.39.2