From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F7A2C7618D for ; Tue, 14 Mar 2023 22:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231356AbjCNWmD (ORCPT ); Tue, 14 Mar 2023 18:42:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231256AbjCNWl7 (ORCPT ); Tue, 14 Mar 2023 18:41:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6B1C37541; Tue, 14 Mar 2023 15:41:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 318CF61A47; Tue, 14 Mar 2023 22:41:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0A4DC433D2; Tue, 14 Mar 2023 22:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678833717; bh=s6IlrideidXiP2FRDZyepR6OUAPx5CL/GzNBpxy/lyA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KjWPkr1+9gglz/7YFCYrvIRAAcuskx48dxq6RXDQROZhnIya6h3HhSKYhE0nTSf5t OrXC260lip8lFK8+4Pm9XfjUAdmK58eimPvgXFXtDAkozgninx/vF7g2EusBBcikjH gPoES119tn804hA+3fXCBA3MZ7PDH92TbGrG28RmHkALJ9da/Qso8bLY1q1iRNxpXh IH/XHB5mZKXHqu+G+uCpIQTtHpZls1IF2YzARdSxW7ixG9Y1xj9Qxn/E3+TSCqI0W6 a2RR35RzpZYeUWYjoOMaKOT/Ou0AioOTdSbonL+DM6YBjPaE87mt/2iF0NU79daUxN DylGDWdztvrbw== Date: Tue, 14 Mar 2023 23:41:54 +0100 From: Andi Shyti To: Linus Walleij Cc: Alexey Khoroshilov , Andi Shyti , Lars-Peter Clausen , lvc-project@linuxtesting.org, Kasumov Ruslan , linux-arm-msm@vger.kernel.org, Bjorn Andersson , linux-kernel@vger.kernel.org, Konrad Dybcio , linux-iio@vger.kernel.org, Andy Gross , Kasumov Ruslan , Jonathan Cameron Subject: Re: [lvc-project] [PATCH] iio: adc: qcom-pm8xxx-xoadc: Remove useless condition in pm8xxx_xoadc_parse_channel() Message-ID: <20230314224154.7gctfkt2mlaz3geg@intel.intel> References: <20230314193709.15208-1-xhxgldhlpfy@gmail.com> <20230314212851.hqbzs5hhed5apcv5@intel.intel> <9aec4249-6457-4e3b-13dd-baf02d4fbfad@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexey and Ruslan, On Tue, Mar 14, 2023 at 11:07:19PM +0100, Linus Walleij wrote: > On Tue, Mar 14, 2023 at 11:03 PM Alexey Khoroshilov > wrote: > > > As far as I can see sentinel is an "empty" element of xoadc_channel in > > the array, i.e. hwchan->datasheet_name works as a sentinel while hwchan > > is always non NULL. > > You're right, I was unable to understand my own code :( At this time of the day I got alarmed too. Happens :) Please ignore my previous comment but still no need for the Fixes: tag from the commit log as it's a cleanup and not a bug fix. Thanks, Andi