* Re: [PATCH RESEND] leds: qcom-lpg: Release node reference before returning
[not found] <ZAI/6w7k7k0ep1x/@ubun2204.myguest.virtualbox.org>
@ 2023-03-15 17:11 ` Lee Jones
0 siblings, 0 replies; only message in thread
From: Lee Jones @ 2023-03-15 17:11 UTC (permalink / raw)
To: Deepak R Varma
Cc: Pavel Machek, linux-leds, linux-kernel, quic_c_skakit,
bjorn.andersson, dianders, marijn.suijten, luca,
Saurabh Singh Sengar, Praveen Kumar
On Sat, 04 Mar 2023, Deepak R Varma wrote:
> The iterator for_each_available_child_of_node() increments the refcount
> of the child node it is processing. Release such a reference when the
> loop needs to breaks due to en error during its execution.
> Issue identified using for_each_child.cocci Coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> Please note:
> - The proposed change is compile tested only. I do not have the
> necessary hardware to perform additional testing. Please suggest if there
> is an alternate means available to further test this change.
> - Included authors/experts for this driver for guidance as suggested by
> Lee Jones <lee@kernel.org> and resending the patch.
>
>
> drivers/leds/rgb/leds-qcom-lpg.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] only message in thread