Re: [PATCH v2 04/11] dt-bindings: test: Add KUnit empty node binding

Rob Herring
2023-03-21T20:09:38Z

On Wed, Mar 15, 2023 at 11:37:21AM -0700, Stephen Boyd wrote:
> Describe a binding for an empty device node used by KUnit tests to
> confirm overlays load properly.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Brendan Higgins <brendan.higgins@linux.dev>
> Cc: David Gow <davidgow@google.com>
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> ---
> .../bindings/test/test,kunit-empty.yaml | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/test/test,kunit-empty.yaml
>
> diff --git a/Documentation/devicetree/bindings/test/test,kunit-empty.yaml b/Documentation/devicetree/bindings/test/test,kunit-empty.yaml
> new file mode 100644
> index 000000000000..592fd06031b8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/test/test,kunit-empty.yaml
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/test,kunit-empty.yaml#

s/clock/test/

'make dt_binding_check' will tell you this.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: KUnit empty node
> +
> +maintainers:
> + - David Gow <davidgow@google.com>
> + - Brendan Higgins <brendanhiggins@google.com>
> +
> +description: |

Don't need '|'

> + An empty node to confirm KUnit can load device tree overlays.
> +
> +properties:
> + compatible:
> + const: test,kunit-empty
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + kunit-node {
> + compatible = "test,kunit-empty";
> + };
> +...
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
>