Re: [PATCH v2 07/11] dt-bindings: kunit: Add fixed rate clk consumer test

Rob Herring
2023-03-21T20:15:38Z

On Wed, Mar 15, 2023 at 11:37:24AM -0700, Stephen Boyd wrote:
> Describe a binding for a device that consumes a fixed rate clk in DT so
> that a KUnit test can get the clk registered by of_fixed_clk_setup() and
> test that it is setup properly.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Brendan Higgins <brendan.higgins@linux.dev>
> Cc: David Gow <davidgow@google.com>
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> ---
> .../kunit/test,clk-kunit-fixed-rate.yaml | 35 +++++++++++++++++++

Some stuff in test and some in kunit? I prefer 'test'.

> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/kunit/test,clk-kunit-fixed-rate.yaml
>
> diff --git a/Documentation/devicetree/bindings/kunit/test,clk-kunit-fixed-rate.yaml b/Documentation/devicetree/bindings/kunit/test,clk-kunit-fixed-rate.yaml
> new file mode 100644
> index 000000000000..58d7826d9c14
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/kunit/test,clk-kunit-fixed-rate.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/kunit/test,clk-kunit-fixed-rate.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: KUnit clk fixed rate test clk consumer
> +
> +maintainers:
> + - Stephen Boyd <sboyd@kernel.org>
> +
> +description: |

Drop '|'

> + A clk consumer of a fixed rate clk used to test the fixed rate clk
> + implementation in the Linux kernel.
> +
> +properties:
> + compatible:
> + const: test,clk-kunit-fixed-rate

I tend to think we should drop 'kunit' from these bindings. You could
use this for different test frameworks.

> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + clock-consumer {
> + compatible = "test,clk-kunit-fixed-rate";
> + clocks = <&fixed_clk>;
> + };
> +...
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
>