From: Qais Yousef <qyousef@layalina.io>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Waiman Long <longman@redhat.com>,
Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>, Hao Luo <haoluo@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it,
claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it,
bristot@redhat.com, mathieu.poirier@linaro.org,
cgroups@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Wei Wang <wvw@google.com>, Rick Yiu <rickyiu@google.com>,
Quentin Perret <qperret@google.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [RFC PATCH 2/3] sched/cpuset: Keep track of SCHED_DEADLINE tasks in cpusets
Date: Wed, 15 Mar 2023 19:25:44 +0000 [thread overview]
Message-ID: <20230315192544.44ufekpbebs2ysub@airbuntu> (raw)
In-Reply-To: <ZBH+AaJV36y/HNXk@localhost.localdomain>
On 03/15/23 17:18, Juri Lelli wrote:
> On 15/03/23 14:49, Qais Yousef wrote:
> > On 03/15/23 12:18, Juri Lelli wrote:
>
> ...
>
> > > +void inc_dl_tasks_cs(struct task_struct *p)
> > > +{
> > > + struct cpuset *cs = task_cs(p);
> >
> > nit:
> >
> > I *think* task_cs() assumes rcu_read_lock() is held, right?
> >
> > Would it make sense to WARN_ON(!rcu_read_lock_held()) to at least
> > annotate the deps?
>
> Think we have that check in task_css_set_check()?
Yes you're right, I didn't go forward enough in the call stack.
It seems to depend on PROVE_RCU, which sounds irrelevant, but I see PROVE_RCU
is actually an alias for PROVE_LOCKING.
Cheers
--
Qais Yousef
next prev parent reply other threads:[~2023-03-15 19:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 12:18 [RFC PATCH 0/3] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Juri Lelli
2023-03-15 12:18 ` [RFC PATCH 1/3] sched/cpuset: Bring back cpuset_mutex Juri Lelli
2023-03-15 12:18 ` [RFC PATCH 2/3] sched/cpuset: Keep track of SCHED_DEADLINE tasks in cpusets Juri Lelli
2023-03-15 14:49 ` Qais Yousef
2023-03-15 17:18 ` Juri Lelli
2023-03-15 19:25 ` Qais Yousef [this message]
2023-03-15 15:46 ` Waiman Long
2023-03-15 17:14 ` Juri Lelli
2023-03-15 18:01 ` Waiman Long
2023-03-15 18:10 ` Waiman Long
2023-03-15 23:27 ` Waiman Long
2023-03-22 14:05 ` Dietmar Eggemann
2023-03-22 13:18 ` Dietmar Eggemann
2023-03-15 12:18 ` [RFC PATCH 3/3] cgroup/cpuset: Iterate only if DEADLINE tasks are present Juri Lelli
2023-03-15 14:55 ` [RFC PATCH 0/3] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Qais Yousef
2023-03-15 17:10 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315192544.44ufekpbebs2ysub@airbuntu \
--to=qyousef@layalina.io \
--cc=agordeev@linux.ibm.com \
--cc=bristot@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=claudio@evidence.eu.com \
--cc=dietmar.eggemann@arm.com \
--cc=gor@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=haoluo@google.com \
--cc=hca@linux.ibm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rickyiu@google.com \
--cc=rostedt@goodmis.org \
--cc=sudeep.holla@arm.com \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox