Re: [PATCH v18 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

Lee Jones
2023-03-17T07:54:18Z

On Fri, 10 Mar 2023, ChiaEn Wu wrote:

> From: ChiYuan Huang <cy_huang@richtek.com>
>
> The MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery
> charger, a USB Type-C & Power Delivery (PD) controller, dual
> Flash LED current sources, a RGB LED driver, a backlight WLED driver,
> a display bias driver and a general LDO for portable devices.
>
> Add support for the MediaTek MT6370 Current Sink Type LED Indicator
> driver. It can control four channels current-sink RGB LEDs with 3 modes:
> constant current, PWM, and breath mode.
>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Co-developed-by: Alice Chen <alice_chen@richtek.com>
> Signed-off-by: Alice Chen <alice_chen@richtek.com>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> ---
> v18:
> - Rename 'MT6370_VENID_MASK' to more human readable
> 'MT6370_VENDOR_ID_MASK'
> - Define the const number vid.
> - Unwrap each line by 100 chars limit.
> - Remove the redudant space in 'mt6370_gen_breath_pattern()' comment for
> patterh data allocation.
> - Define a sub function 'mt6370_assign_multicolor_info()' to tidy up
> 'mt6370_init_led_properties()' for multicolor case.
> - Define a sub function 'mt6370_multicolor_led_register' to tidy up
> 'mt6370_led_register()' for multicolor case.
> - Refine 'fwnode_handle_put' in probe function with 'goto'.
> ---
> drivers/leds/rgb/Kconfig | 13 +
> drivers/leds/rgb/Makefile | 1 +
> drivers/leds/rgb/leds-mt6370-rgb.c | 1010 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 1024 insertions(+)
> create mode 100644 drivers/leds/rgb/leds-mt6370-rgb.c

Applied, thanks

--
Lee Jones [李琼斯]