Re: [PATCH 05/37] drm/ttm/ttm_bo: Provide a missing 'bulk' description and correct misnaming of 'placement'

Christian König
2023-03-17T08:42:56Z

Am 17.03.23 um 09:16 schrieb Lee Jones:
> 'bulk' description taken from another in the same file.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/ttm/ttm_bo.c:98: warning: Function parameter or member 'bulk' not described in 'ttm_bo_set_bulk_move'
> drivers/gpu/drm/ttm/ttm_bo.c:768: warning: Function parameter or member 'placement' not described in 'ttm_bo_mem_space'
> drivers/gpu/drm/ttm/ttm_bo.c:768: warning: Excess function parameter 'proposed_placement' description in 'ttm_bo_mem_space'
>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> Signed-off-by: Lee Jones <lee@kernel.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

Going to upstream that through drm-misc-next in a minute.

Thanks,
Christian.

> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 459f1b4440daa..d056d28f8758a 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -84,6 +84,7 @@ EXPORT_SYMBOL(ttm_bo_move_to_lru_tail);
> * ttm_bo_set_bulk_move - update BOs bulk move object
> *
> * @bo: The buffer object.
> + * @bulk: bulk move structure
> *
> * Update the BOs bulk move object, making sure that resources are added/removed
> * as well. A bulk move allows to move many resource on the LRU at once,
> @@ -748,7 +749,7 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,
> *
> * @bo: Pointer to a struct ttm_buffer_object. the data of which
> * we want to allocate space for.
> - * @proposed_placement: Proposed new placement for the buffer object.
> + * @placement: Proposed new placement for the buffer object.
> * @mem: A struct ttm_resource.
> * @ctx: if and how to sleep, lock buffers and alloc memory
> *