From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5391EC7618A for ; Mon, 20 Mar 2023 01:03:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231375AbjCTBDd (ORCPT ); Sun, 19 Mar 2023 21:03:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231314AbjCTBCs (ORCPT ); Sun, 19 Mar 2023 21:02:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8E012364E; Sun, 19 Mar 2023 17:57:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BD1D7B80D4A; Mon, 20 Mar 2023 00:56:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B661CC433D2; Mon, 20 Mar 2023 00:56:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679273778; bh=vLPdEk4Fjw1BwPXpeXL7Y2+eIf5Xwbn9TjCRARSDY0U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ubGDHpDW7BbdOc9xjwRpE1t6nG3HdhdzCo1gx7kxWyOgctbnJPu8U8dHkRwOLDLVW VZ98DJ753k716SQOzWaV21VW73mpq6utUdtLvYSllh3fqrPwQLHn1XeBJoLPP5wmzq lHvvkE0qmR6lCL805MUQI7BBzTqu04Bnr+QaF0dIMCLnu1UO154VKGUbjQ14plqwq7 FSWL5MQKxODPXq1ltOROcw1GcJJXhDzOcL9+kiC/cDf+J/5ThpcBU68cBg5C2e1Hgb iDHPb0dXCr/pmEPicxDTNL/pU6nF/hRk/NbYQBdAVXo7kje0IhllyOYBpbj9Q4SLZ+ mHcSYvd1PkRpg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kang Chen , Xiang Chen , "Martin K . Petersen" , Sasha Levin , jejb@linux.ibm.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 08/15] scsi: hisi_sas: Check devm_add_action() return value Date: Sun, 19 Mar 2023 20:55:52 -0400 Message-Id: <20230320005559.1429040-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230320005559.1429040-1-sashal@kernel.org> References: <20230320005559.1429040-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kang Chen [ Upstream commit 06d1a90de60208054cca15ef200138cfdbb642a9 ] In case devm_add_action() fails, check it in the caller of interrupt_preinit_v3_hw(). Link: https://lore.kernel.org/r/20230227031030.893324-1-void0red@gmail.com Signed-off-by: Kang Chen Acked-by: Xiang Chen Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c index cd41dc061d874..65971bd80186b 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -2402,8 +2402,7 @@ static int interrupt_preinit_v3_hw(struct hisi_hba *hisi_hba) hisi_hba->cq_nvecs = vectors - BASE_VECTORS_V3_HW; shost->nr_hw_queues = hisi_hba->cq_nvecs; - devm_add_action(&pdev->dev, hisi_sas_v3_free_vectors, pdev); - return 0; + return devm_add_action(&pdev->dev, hisi_sas_v3_free_vectors, pdev); } static int interrupt_init_v3_hw(struct hisi_hba *hisi_hba) -- 2.39.2