Re: [PATCH v7 6/7] iommu/ioasid: Rename INVALID_IOASID

Jacob Pan
2023-03-20T20:35:09Z

Hi Dave,

On Mon, 20 Mar 2023 11:58:14 -0700, Dave Hansen <dave.hansen@intel.com>
wrote:

> On 3/20/23 11:59, Jacob Pan wrote:
> > --- a/arch/x86/kernel/traps.c
> > +++ b/arch/x86/kernel/traps.c
> > @@ -40,7 +40,10 @@
> > #include <linux/io.h>
> > #include <linux/hardirq.h>
> > #include <linux/atomic.h>
> > -#include <linux/ioasid.h>
> > +
> > +#ifdef CONFIG_IOMMU_SVA
> > +#include <linux/iommu.h>
> > +#endif
>
> What's the deal with the #ifdef'd #include?
>
> What's the harm of just making it unconditional?
No harm for this version. I will remove.

Thanks,

Jacob