Re: [PATCH v2 07/12] sched: Replace rq->curr access w/ rq_curr(rq)

John Stultz
2023-03-22T03:50:55Z

On Tue, Mar 21, 2023 at 4:12 AM kernel test robot <lkp@intel.com> wrote:
>
> Hi John,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on tip/sched/core]
> [also build test ERROR on tip/locking/core tip/master tip/auto-latest linus/master v6.3-rc3 next-20230321]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/John-Stultz/locking-ww_mutex-Remove-wakeups-from-under-mutex-wait_lock/20230321-074149
> patch link: https://lore.kernel.org/r/20230320233720.3488453-8-jstultz%40google.com
> patch subject: [PATCH v2 07/12] sched: Replace rq->curr access w/ rq_curr(rq)
> config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20230321/202303211827.IXnKJ5rO-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> reproduce (this is a W=1 build):
> # https://github.com/intel-lab-lkp/linux/commit/77507c3a77e09cdc627a73364246f252d918de41
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review John-Stultz/locking-ww_mutex-Remove-wakeups-from-under-mutex-wait_lock/20230321-074149
> git checkout 77507c3a77e09cdc627a73364246f252d918de41
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=x86_64 olddefconfig
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303211827.IXnKJ5rO-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/rculist.h:11,
> from include/linux/sched/signal.h:5,
> from include/linux/sched/cputime.h:5,
> from kernel/sched/build_policy.c:17:
> kernel/sched/cputime.c: In function 'kcpustat_field':
> >> kernel/sched/cputime.c:997:42: error: 'struct rq' has no member named 'curr'
> 997 | curr = rcu_dereference(rq->curr);
> | ^~

Ah! Thanks for catching this. I've fixed it up for the next revision.
-john