From: Arnd Bergmann <arnd@kernel.org>
To: "Marcel Holtmann" <marcel@holtmann.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Neeraj Sanjay Kale" <neeraj.sanjaykale@nxp.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Bluetooth: NXP: select CONFIG_CRC8
Date: Wed, 22 Mar 2023 12:16:27 +0100 [thread overview]
Message-ID: <20230322111636.1028838-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
The driver needs both CRC32 and CRC8 to link correctly:
ld.lld: error: undefined symbol: crc8_populate_msb
>>> referenced by btnxpuart.c
>>> drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a
ld.lld: error: undefined symbol: crc8
>>> referenced by btnxpuart.c
>>> drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a
Fixes: 3e662aa4453a ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/bluetooth/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 0703bdd44140..f84322d375de 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -469,6 +469,7 @@ config BT_NXPUART
tristate "NXP protocol support"
depends on SERIAL_DEV_BUS
select CRC32
+ select CRC8
help
NXP is serial driver required for NXP Bluetooth
devices with UART interface.
--
2.39.2
next reply other threads:[~2023-03-22 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 11:16 Arnd Bergmann [this message]
2023-03-22 12:35 ` [PATCH] Bluetooth: NXP: select CONFIG_CRC8 Ilpo Järvinen
2023-03-22 23:00 ` patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322111636.1028838-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=neeraj.sanjaykale@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox